From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Maxim Uvarov <maxim.uvarov@linaro.org>
Subject: Re: [PATCH 09/11] hw/gpio/pl061: Convert to 3-phase reset and assert GPIO lines correctly on reset
Date: Tue, 6 Jul 2021 18:33:56 -0700 [thread overview]
Message-ID: <31d9f554-8094-01ff-a7f4-a2645016d1eb@linaro.org> (raw)
In-Reply-To: <20210702104018.19881-10-peter.maydell@linaro.org>
On 7/2/21 3:40 AM, Peter Maydell wrote:
> The PL061 comes out of reset with all its lines configured as input,
> which means they might need to be pulled to 0 or 1 depending on the
> 'pullups' and 'pulldowns' properties. Currently we do not assert
> these lines on reset; they will only be set whenever the guest first
> touches a register that triggers a call to pl061_update().
>
> Convert the device to three-phase reset so we have a place where we
> can safely call qemu_set_irq() to set the floating lines to their
> correct values.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> hw/gpio/pl061.c | 29 +++++++++++++++++++++++++----
> hw/gpio/trace-events | 1 +
> 2 files changed, 26 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-07-07 1:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 10:40 [PATCH 00/11] hw/arm: Make virt board secure powerdown/reset work Peter Maydell
2021-07-02 10:40 ` [PATCH 01/11] hw/gpio/gpio_pwr: use shutdown function for reboot Peter Maydell
2021-07-02 10:40 ` [PATCH 02/11] hw/gpio/pl061: Convert DPRINTF to tracepoints Peter Maydell
2021-07-02 10:53 ` Philippe Mathieu-Daudé
2021-07-07 1:19 ` Richard Henderson
2021-07-02 10:40 ` [PATCH 03/11] hw/gpio/pl061: Clean up read/write offset handling logic Peter Maydell
2021-07-02 11:02 ` Philippe Mathieu-Daudé
2021-07-02 11:45 ` Peter Maydell
2021-07-07 1:25 ` Richard Henderson
2021-07-08 9:39 ` Peter Maydell
2021-07-08 15:07 ` Richard Henderson
2021-07-07 1:21 ` Richard Henderson
2021-07-02 10:40 ` [PATCH 04/11] hw/gpio/pl061: Add tracepoints for register read and write Peter Maydell
2021-07-02 10:55 ` Philippe Mathieu-Daudé
2021-07-07 1:26 ` Richard Henderson
2021-07-02 10:40 ` [PATCH 05/11] hw/gpio/pl061: Document the interface of this device Peter Maydell
2021-07-07 1:26 ` Richard Henderson
2021-07-02 10:40 ` [PATCH 06/11] hw/gpio/pl061: Honour Luminary PL061 PUR and PDR registers Peter Maydell
2021-07-07 1:29 ` Richard Henderson
2021-07-02 10:40 ` [PATCH 07/11] hw/gpio/pl061: Make pullup/pulldown of outputs configurable Peter Maydell
2021-07-07 1:31 ` Richard Henderson
2021-07-02 10:40 ` [PATCH 08/11] hw/arm/virt: Make PL061 GPIO lines pulled low, not high Peter Maydell
2021-07-07 1:32 ` Richard Henderson
2021-07-02 10:40 ` [PATCH 09/11] hw/gpio/pl061: Convert to 3-phase reset and assert GPIO lines correctly on reset Peter Maydell
2021-07-02 10:56 ` Philippe Mathieu-Daudé
2021-07-07 1:33 ` Richard Henderson [this message]
2021-07-02 10:40 ` [PATCH 10/11] hw/gpio/pl061: Document a shortcoming in our implementation Peter Maydell
2021-07-02 10:57 ` Philippe Mathieu-Daudé
2021-07-02 10:40 ` [PATCH 11/11] hw/arm/stellaris: Expand comment about handling of OLED chipselect Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31d9f554-8094-01ff-a7f4-a2645016d1eb@linaro.org \
--to=richard.henderson@linaro.org \
--cc=maxim.uvarov@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).