From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elFRT-0006hY-Uv for qemu-devel@nongnu.org; Mon, 12 Feb 2018 09:50:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elFRS-0000d3-Qj for qemu-devel@nongnu.org; Mon, 12 Feb 2018 09:50:51 -0500 References: <20180207163622.29935-1-pbonzini@redhat.com> <20180207163622.29935-3-pbonzini@redhat.com> <20180208013517.GB24289@lemon.usersys.redhat.com> <5ac0b76e-213a-60c3-c010-87512d3a564a@redhat.com> <20180212135206.GG5103@localhost.localdomain> <81af35f9-4934-0c21-e3b1-b27c2fa7fdd9@redhat.com> <20180212143040.GH5103@localhost.localdomain> <3d6031b0-7d75-c3ab-e466-ce3d87d630df@redhat.com> <20180212144824.GI5103@localhost.localdomain> From: Paolo Bonzini Message-ID: <31e295bd-3012-c34c-a96d-54122557b20c@redhat.com> Date: Mon, 12 Feb 2018 15:50:41 +0100 MIME-Version: 1.0 In-Reply-To: <20180212144824.GI5103@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Fam Zheng , qemu-devel@nongnu.org, qemu-block@nongnu.org On 12/02/2018 15:48, Kevin Wolf wrote: > Am 12.02.2018 um 15:32 hat Paolo Bonzini geschrieben: >> Okay, we are in agreement about this and you expressed very well why I >> (at the gut feeling level) didn't like the old op blockers. But you >> bypassed the real question, which is: should I send a pull request for >> these two patches or not? :) > > I didn't spell it out that explicitly, but this is essentially a NACK. > I'd very much prefer if you could replace it with the proper solution. > Of course, we can always make exceptions when there is a good reason, > but with 2.12 still two months away, I doubt we have one. Ok, I don't mind explicitness. I'll keep these two patches in the queue for now. Paolo