From: Stefan Berger <stefanb@linux.ibm.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v5 0/3] tpm: Add missing ACPI device identification objects
Date: Tue, 4 Jan 2022 13:14:34 -0500 [thread overview]
Message-ID: <31ef626c-ad4b-b948-41c9-5627f08163ba@linux.ibm.com> (raw)
In-Reply-To: <YdSNUYNxa/g1P3BR@redhat.com>
On 1/4/22 13:09, Daniel P. Berrangé wrote:
> On Tue, Jan 04, 2022 at 12:58:03PM -0500, Stefan Berger wrote:
>> This series of patches adds missing ACPI device identification objects _STR
>> and _UID to TPM 1.2 and TPM 2 ACPI tables.
> What was the practical impact on guests (if any) from these ACPI
> objects being missing ?
As discussed in v4: I don't know if there's software relying on this or
just a user who found these to be missing:
https://gitlab.com/qemu-project/qemu/-/issues/708
I can only say that these entries were missing, so I added them. It
makes TPM ACPI more complete, for sure. Maybe someone else knows more if
there's something out there that actually needs this. I'd be curious as
well.
Stefan
>
> Regards,
> Daniel
prev parent reply other threads:[~2022-01-04 18:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 17:58 [PATCH v5 0/3] tpm: Add missing ACPI device identification objects Stefan Berger
2022-01-04 17:58 ` [PATCH v5 1/3] tests: acpi: prepare for updated TPM related tables Stefan Berger
2022-01-06 16:56 ` Igor Mammedov
2022-01-04 17:58 ` [PATCH v5 2/3] acpi: tpm: Add missing device identification objects Stefan Berger
2022-01-06 8:36 ` Igor Mammedov
2022-01-06 11:40 ` Michael S. Tsirkin
2022-01-06 13:53 ` Stefan Berger
2022-01-06 13:56 ` Michael S. Tsirkin
2022-01-06 14:01 ` Stefan Berger
2022-01-06 16:55 ` Igor Mammedov
2022-01-06 18:07 ` Stefan Berger
2022-01-06 17:38 ` Ani Sinha
2022-01-04 17:58 ` [PATCH v5 3/3] tests: acpi: Add updated TPM related tables Stefan Berger
2022-01-04 18:09 ` [PATCH v5 0/3] tpm: Add missing ACPI device identification objects Daniel P. Berrangé
2022-01-04 18:14 ` Stefan Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31ef626c-ad4b-b948-41c9-5627f08163ba@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).