From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: laurent@vivier.eu
Subject: Re: [Qemu-devel] [PATCH v2 3/8] target/sparc: Define an enumeration for accessing env->regwptr
Date: Sun, 19 May 2019 20:09:45 -0700 [thread overview]
Message-ID: <31f54a09-23bc-9d66-a720-9027c48d27fa@linaro.org> (raw)
In-Reply-To: <492ec7a8-b5bf-b873-8ed2-2a1faf0968b4@redhat.com>
On 5/14/19 10:44 PM, Philippe Mathieu-Daudé wrote:
>> +/* Windowed register indexes. */
>> +enum {
>> + WREG_O0,
>> + WREG_O1,
>> + WREG_O2,
>> + WREG_O3,
>> + WREG_O4,
>> + WREG_O5,
>> + WREG_O6,
>> + WREG_O7,
>> +
>> + WREG_L0,
>> + WREG_L1,
>> + WREG_L2,
>> + WREG_L3,
>> + WREG_L4,
>> + WREG_L5,
>> + WREG_L6,
>> + WREG_L7,
>> +
>> + WREG_I0,
>> + WREG_I1,
>> + WREG_I2,
>> + WREG_I3,
>> + WREG_I4,
>> + WREG_I5,
>> + WREG_I6,
>> + WREG_I7,
>
> I'd feel safer if you initialize those enums (better safe than sorry!).
What are you suggesting? This is how C works, and always has...
r~
next prev parent reply other threads:[~2019-05-20 3:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 3:27 [Qemu-devel] [PATCH v2 0/8] linux-user sparc fixes Richard Henderson
2019-05-10 3:27 ` [Qemu-devel] [PATCH v2 1/8] linux-user: Disallow setting newsp for fork Richard Henderson
2019-05-15 0:31 ` Richard Henderson
2019-05-10 3:27 ` [Qemu-devel] [PATCH v2 2/8] linux-user: Pass the parent env to cpu_clone_regs Richard Henderson
2019-05-10 3:27 ` [Qemu-devel] [PATCH v2 3/8] target/sparc: Define an enumeration for accessing env->regwptr Richard Henderson
2019-05-15 5:44 ` Philippe Mathieu-Daudé
2019-05-20 3:09 ` Richard Henderson [this message]
2019-05-10 3:27 ` [Qemu-devel] [PATCH v2 4/8] linux-user/sparc: Use WREG constants in sparc/target_cpu.h Richard Henderson
2019-05-10 3:27 ` [Qemu-devel] [PATCH v2 5/8] linux-user/sparc: Use WREG constants in sparc/signal.c Richard Henderson
2019-05-10 3:27 ` [Qemu-devel] [PATCH v2 6/8] linux-user/sparc: Fix cpu_clone_regs Richard Henderson
2019-05-10 3:27 ` [Qemu-devel] [PATCH v2 7/8] linux-user/sparc: Flush register windows before clone Richard Henderson
2019-05-10 3:27 ` [Qemu-devel] [PATCH v2 8/8] scripts/qemu-binfmt-conf: Update for sparc64 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31f54a09-23bc-9d66-a720-9027c48d27fa@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).