From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLo0N-00047Z-Ax for qemu-devel@nongnu.org; Wed, 01 May 2019 08:06:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLo0K-0006e4-AD for qemu-devel@nongnu.org; Wed, 01 May 2019 08:06:31 -0400 References: <20190428155451.15653-1-thuth@redhat.com> <20190428155451.15653-3-thuth@redhat.com> <877eba77ps.fsf@zen.linaroharston> From: Eric Blake Message-ID: <3205a43e-20f3-b152-2f8c-a450dd8e7cdc@redhat.com> Date: Wed, 1 May 2019 07:06:10 -0500 MIME-Version: 1.0 In-Reply-To: <877eba77ps.fsf@zen.linaroharston> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F45pTOfiaZ1h9EkmYDIahfkltsXurWfiX" Subject: Re: [Qemu-devel] [PATCH v2 2/8] tests/qemu-iotests/005: Add a sanity check for large sparse file support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Thomas Huth Cc: qemu-devel@nongnu.org, Fam Zheng , qemu-block@nongnu.org, Ed Maste , Christophe Fergeau , Kevin Wolf , Max Reitz , Li-Wen Hsu , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Wainer dos Santos Moschetta , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --F45pTOfiaZ1h9EkmYDIahfkltsXurWfiX From: Eric Blake To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Thomas Huth Cc: qemu-devel@nongnu.org, Fam Zheng , qemu-block@nongnu.org, Ed Maste , Christophe Fergeau , Kevin Wolf , Max Reitz , Li-Wen Hsu , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Wainer dos Santos Moschetta , Markus Armbruster Message-ID: <3205a43e-20f3-b152-2f8c-a450dd8e7cdc@redhat.com> Subject: Re: [PATCH v2 2/8] tests/qemu-iotests/005: Add a sanity check for large sparse file support References: <20190428155451.15653-1-thuth@redhat.com> <20190428155451.15653-3-thuth@redhat.com> <877eba77ps.fsf@zen.linaroharston> In-Reply-To: <877eba77ps.fsf@zen.linaroharston> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/1/19 6:08 AM, Alex Benn=C3=A9e wrote: >=20 > Thomas Huth writes: >=20 >> "check -raw 005" fails when running on ext4 filesystems - these do not= >> support such large sparse files. Use the same check as in test 220 to >> skip the test in this case. >> >> Suggested-by: Eric Blake >> Signed-off-by: Thomas Huth >> --- >> tests/qemu-iotests/005 | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/tests/qemu-iotests/005 b/tests/qemu-iotests/005 >> index 2fef63af88..6136ced5c8 100755 >> --- a/tests/qemu-iotests/005 >> +++ b/tests/qemu-iotests/005 >> @@ -55,6 +55,15 @@ if [ "$IMGPROTO" =3D "sheepdog" ]; then >> _notrun "image protocol $IMGPROTO does not support large image si= zes" >> fi >> >> +# Sanity check: For raw, we require a file system that permits the cr= eation >> +# of a HUGE (but very sparse) file. tmpfs works, ext4 does not. >=20 > Is this comment correct? Running on my ext4 home partition this test > seems to be running fine and not skipping. Indeed: >> +if [ "$IMGFMT" =3D "raw" ]; then >> + if ! truncate --size=3D5T "$TEST_IMG"; then 5T fits on ext4 but not ext3. This is not a straight copy from 220 (where the size in question was even bigger, at 513T), so the comment is indeed slightly inaccurate; it may be worth figuring out which file system actually failed to update the comment. But the code change is correct once the comments are fixed. Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --F45pTOfiaZ1h9EkmYDIahfkltsXurWfiX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlzJi7MACgkQp6FrSiUn Q2ruHgf9E8G/M1Rflj6m0/pjpBxJKZBbQaIu1+DYVqvQ++Rt5Euzuv69ikKVl34O /eGor9gQYRUvaUK0eqSAijvbd2KEcjqrq9M5OmNSqfCbiNamQNl1kFUAa0XmX+/9 wVwkAwJ3QX8EYRhdOZdELOU8UuM/kN7OLpCM23Yjk25HQ1Q8eoUDztCKTZ5+3CTW kZIYXJ2VR0//1d8+rT/gVKVoiXQOq6KyBDoCV7MYH9liVjuLVufpQ7NnE+Gn9UOO md+awGMPwYD1B/qvAkoBrjXVm+s7v2F7925c1z2c2rGxfjV5iXuhWbwwSAlXdEe9 IKquF2Iq6ptyT3kLVp7LgxbgNWQKKw== =v6jz -----END PGP SIGNATURE----- --F45pTOfiaZ1h9EkmYDIahfkltsXurWfiX-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D61AFC43219 for ; Wed, 1 May 2019 12:07:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A33A20651 for ; Wed, 1 May 2019 12:07:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A33A20651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:56308 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLo1Z-0004li-Rl for qemu-devel@archiver.kernel.org; Wed, 01 May 2019 08:07:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLo0N-00047Z-Ax for qemu-devel@nongnu.org; Wed, 01 May 2019 08:06:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLo0K-0006e4-AD for qemu-devel@nongnu.org; Wed, 01 May 2019 08:06:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33570) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLo0D-0006bO-Rk; Wed, 01 May 2019 08:06:22 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FF653082B3F; Wed, 1 May 2019 12:06:20 +0000 (UTC) Received: from [10.3.116.15] (ovpn-116-15.phx2.redhat.com [10.3.116.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EBF478B3A; Wed, 1 May 2019 12:06:12 +0000 (UTC) To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Thomas Huth References: <20190428155451.15653-1-thuth@redhat.com> <20190428155451.15653-3-thuth@redhat.com> <877eba77ps.fsf@zen.linaroharston> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <3205a43e-20f3-b152-2f8c-a450dd8e7cdc@redhat.com> Date: Wed, 1 May 2019 07:06:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <877eba77ps.fsf@zen.linaroharston> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F45pTOfiaZ1h9EkmYDIahfkltsXurWfiX" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 01 May 2019 12:06:20 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH v2 2/8] tests/qemu-iotests/005: Add a sanity check for large sparse file support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Ed Maste , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Christophe Fergeau , Max Reitz , Wainer dos Santos Moschetta , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Li-Wen Hsu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190501120610.AIoKWvuvW_FTw5jkF_R5JG6WRwcVb_kcdQtqLtcbh3s@z> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --F45pTOfiaZ1h9EkmYDIahfkltsXurWfiX From: Eric Blake To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Thomas Huth Cc: qemu-devel@nongnu.org, Fam Zheng , qemu-block@nongnu.org, Ed Maste , Christophe Fergeau , Kevin Wolf , Max Reitz , Li-Wen Hsu , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Wainer dos Santos Moschetta , Markus Armbruster Message-ID: <3205a43e-20f3-b152-2f8c-a450dd8e7cdc@redhat.com> Subject: Re: [PATCH v2 2/8] tests/qemu-iotests/005: Add a sanity check for large sparse file support References: <20190428155451.15653-1-thuth@redhat.com> <20190428155451.15653-3-thuth@redhat.com> <877eba77ps.fsf@zen.linaroharston> In-Reply-To: <877eba77ps.fsf@zen.linaroharston> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/1/19 6:08 AM, Alex Benn=C3=A9e wrote: >=20 > Thomas Huth writes: >=20 >> "check -raw 005" fails when running on ext4 filesystems - these do not= >> support such large sparse files. Use the same check as in test 220 to >> skip the test in this case. >> >> Suggested-by: Eric Blake >> Signed-off-by: Thomas Huth >> --- >> tests/qemu-iotests/005 | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/tests/qemu-iotests/005 b/tests/qemu-iotests/005 >> index 2fef63af88..6136ced5c8 100755 >> --- a/tests/qemu-iotests/005 >> +++ b/tests/qemu-iotests/005 >> @@ -55,6 +55,15 @@ if [ "$IMGPROTO" =3D "sheepdog" ]; then >> _notrun "image protocol $IMGPROTO does not support large image si= zes" >> fi >> >> +# Sanity check: For raw, we require a file system that permits the cr= eation >> +# of a HUGE (but very sparse) file. tmpfs works, ext4 does not. >=20 > Is this comment correct? Running on my ext4 home partition this test > seems to be running fine and not skipping. Indeed: >> +if [ "$IMGFMT" =3D "raw" ]; then >> + if ! truncate --size=3D5T "$TEST_IMG"; then 5T fits on ext4 but not ext3. This is not a straight copy from 220 (where the size in question was even bigger, at 513T), so the comment is indeed slightly inaccurate; it may be worth figuring out which file system actually failed to update the comment. But the code change is correct once the comments are fixed. Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --F45pTOfiaZ1h9EkmYDIahfkltsXurWfiX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlzJi7MACgkQp6FrSiUn Q2ruHgf9E8G/M1Rflj6m0/pjpBxJKZBbQaIu1+DYVqvQ++Rt5Euzuv69ikKVl34O /eGor9gQYRUvaUK0eqSAijvbd2KEcjqrq9M5OmNSqfCbiNamQNl1kFUAa0XmX+/9 wVwkAwJ3QX8EYRhdOZdELOU8UuM/kN7OLpCM23Yjk25HQ1Q8eoUDztCKTZ5+3CTW kZIYXJ2VR0//1d8+rT/gVKVoiXQOq6KyBDoCV7MYH9liVjuLVufpQ7NnE+Gn9UOO md+awGMPwYD1B/qvAkoBrjXVm+s7v2F7925c1z2c2rGxfjV5iXuhWbwwSAlXdEe9 IKquF2Iq6ptyT3kLVp7LgxbgNWQKKw== =v6jz -----END PGP SIGNATURE----- --F45pTOfiaZ1h9EkmYDIahfkltsXurWfiX--