Re: [Qemu-devel] [PATCH 1/3] scsi: move lsi53c895a structures and defines into separate lsi53c895a.h file

[Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>]

On 06/09/18 12:52, Thomas Huth wrote:

> On 2018-09-06 07:57, Mark Cave-Ayland wrote:
>> There is also one small change to the new header file which is the addition
>> of the previously missing LSI53C810 define.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> ---
>>  hw/scsi/lsi53c895a.c         | 116 +-----------------------------------
>>  include/hw/scsi/lsi53c895a.h | 137 +++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 138 insertions(+), 115 deletions(-)
>>  create mode 100644 include/hw/scsi/lsi53c895a.h
> [...]
>> diff --git a/include/hw/scsi/lsi53c895a.h b/include/hw/scsi/lsi53c895a.h
>> new file mode 100644
>> index 0000000000..d80cb78c69
>> --- /dev/null
>> +++ b/include/hw/scsi/lsi53c895a.h
>> @@ -0,0 +1,137 @@
>> +/*
>> + * QEMU LSI53C895A SCSI Host Bus Adapter emulation
>> + *
>> + * Copyright (c) 2006 CodeSourcery.
>> + * Written by Paul Brook
>> + *
>> + * This code is licensed under the LGPL.
>> + */
>> +
>> +#ifndef LSI_H
>> +#define LSI_H
>> +
>> +#include "qemu/osdep.h"
> 
> Please don't include osdep.h from a header, that should only be done
> from .c files.

Ah yes, my mistake (obviously it was a cut/paste from the .c file).

I wonder if this is something to teach checkpatch about?


ATB,

Mark.