From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7sYS-00035d-7d for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:22:48 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7sYN-00033X-Jb for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:22:47 -0500 Received: from [199.232.76.173] (port=57144 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7sYN-00033J-D9 for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:22:43 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:62331) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N7sYM-0001Bt-Rz for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:22:43 -0500 Message-Id: <32190714.3251257866557624.JavaMail.servlet@kundenserver> From: Laurent Vivier Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 10 Nov 2009 16:22:37 +0100 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: avi@redhat.com, scottt.tw@gmail.com Cc: qemu-devel@nongnu.org >>> + =C2=A0 =C2=A0s->temperature++; >>> >> You're going to overheat very quickly. >> Apart from making the driver work, is this actually useful? > >I wanted the temperature to change with time to give a sense of >"something is happening" ^_^ > >The main user I had in mind was someone new to USB and Linux driver=20 >development >following gregkh's driver tutorial: >http://www.kroah.com/linux/talks/ols_2005_driver_tutorial/ >My thinking was that if the temperature never changes, all the USB >packets generated in the 'read_int_callback" >part of the driver would seem like a waste of effort. > Perhaps you could read temperature samples from a file... Regards, Laurent --=20 --------------------- Laurent@vivier.eu --------------------- "Tout ce qui est impossible reste =C3=A0 accomplir" Jules Verne "Things are only impossible until they're not" Jean-Luc Picard