Re: [PATCH v1 06/24] s390x/diag: Implement DIAG 320 subcode 1

[Collin Walling <walling@linux.ibm.com>]

On 4/11/25 9:57 AM, Thomas Huth wrote:
> On 08/04/2025 17.55, Zhuoying Cai wrote:
>> DIAG 320 subcode 1 provides information needed to determine
>> the amount of storage to store one or more certificates.
>>
>> The subcode value is denoted by setting the left-most bit
>> of an 8-byte field.
>>
>> The verification-certificate-storage-size block (VCSSB) contains
>> the output data when the operation completes successfully.
>>
>> Signed-off-by: Zhuoying Cai <zycai@linux.ibm.com>
>> ---
>>   include/hw/s390x/ipl/diag320.h | 25 ++++++++++++++++++++++
>>   target/s390x/diag.c            | 39 +++++++++++++++++++++++++++++++++-
>>   2 files changed, 63 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/hw/s390x/ipl/diag320.h b/include/hw/s390x/ipl/diag320.h
>> index d6f70c65df..ded336df25 100644
>> --- a/include/hw/s390x/ipl/diag320.h
>> +++ b/include/hw/s390x/ipl/diag320.h
>> @@ -13,7 +13,32 @@
>>   #define S390X_DIAG320_H
>>   
>>   #define DIAG_320_SUBC_QUERY_ISM     0
>> +#define DIAG_320_SUBC_QUERY_VCSI    1
>>   
>>   #define DIAG_320_RC_OK              0x0001
>> +#define DIAG_320_RC_NOMEM           0x0202
>> +
>> +#define VCSSB_MAX_LEN   128
>> +#define VCE_HEADER_LEN  128
>> +#define VCB_HEADER_LEN  64
>> +
>> +#define DIAG_320_ISM_QUERY_VCSI     0x4000000000000000
>> +
>> +struct VerificationCertificateStorageSizeBlock {
>> +    uint32_t length;
>> +    uint8_t reserved0[3];
>> +    uint8_t version;
>> +    uint32_t reserved1[6];
>> +    uint16_t totalvc;
>> +    uint16_t maxvc;
>> +    uint32_t reserved3[7];
>> +    uint32_t maxvcelen;
>> +    uint32_t reserved4[3];
>> +    uint32_t largestvcblen;
>> +    uint32_t totalvcblen;
>> +    uint32_t reserved5[10];
>> +} QEMU_PACKED;
>> +typedef struct VerificationCertificateStorageSizeBlock \
>> +VerificationCertificateStorageSizeBlock;
> 
> That's quite a long name, maybe shorten to VerificationCertStorageBlock or 
> something similar?
> 

I think it would benefit many of the data structures using the
"VerificationCertificate" prefix to be short-handed to "VC".

[...]

-- 
Regards,
  Collin