From: David Hildenbrand <david@redhat.com>
To: Yang Zhong <yang.zhong@intel.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, philmd@redhat.com, peterx@redhat.com
Subject: Re: [PATCH v3] remote/memory: Replace share parameter with ram_flags
Date: Fri, 9 Jul 2021 10:13:20 +0200 [thread overview]
Message-ID: <32477171-db5b-514f-cb6e-b50bd142dc3e@redhat.com> (raw)
In-Reply-To: <20210709052800.63588-1-yang.zhong@intel.com>
On 09.07.21 07:28, Yang Zhong wrote:
> Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to
> qemu_ram_alloc_from_fd()")
>
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
> hw/remote/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/remote/memory.c b/hw/remote/memory.c
> index 472ed2a272..6e21ab1a45 100644
> --- a/hw/remote/memory.c
> +++ b/hw/remote/memory.c
> @@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
> subregion = g_new(MemoryRegion, 1);
> memory_region_init_ram_from_fd(subregion, NULL,
> name, sysmem_info->sizes[region],
> - true, msg->fds[region],
> + RAM_SHARED, msg->fds[region],
> sysmem_info->offsets[region],
> errp);
>
>
Just an info: no need to resend for added RBs or ACKs. The maintainer
will usually simply pick them up while picking up your patch. :)
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-07-09 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 5:28 [PATCH v3] remote/memory: Replace share parameter with ram_flags Yang Zhong
2021-07-09 8:13 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32477171-db5b-514f-cb6e-b50bd142dc3e@redhat.com \
--to=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).