From: Ben Taylor <sol10x86@cox.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Comment for Solaris fix for the HPTC
Date: Sat, 15 Sep 2007 17:53:54 -0400 [thread overview]
Message-ID: <32504809.1189893234270.JavaMail.root@eastrmwml11> (raw)
Compiling the latest CVS code, I found that a function in vl.c uses a define
called ULONG_LONG_MAX. The value is defined in solaris's sys/types.h,
but only on _LP64 builds, so 32-bit builds won't pickup if I redefine it as
ULONG_MAX.
I'm looking for comments on this patch.
--- qemu.ORIG/vl.h 2007-08-26 13:46:00.000000000 -0400
+++ qemu/vl.h 2007-09-15 17:59:24.179299000 -0400
@@ -49,6 +49,12 @@
#define ENOMEDIUM ENODEV
#endif
+#ifdef __sun__
+/* Have to define this for Solaris as ULONG_LONG_MAX is not defined
+ anywhere. ULONG_MAX is correct only on _LP64 systems */
+#define ULONG_LONG_MAX 18446744073709551615UL
+#endif
+
#ifdef _WIN32
#include <windows.h>
#define fsync _commit
next reply other threads:[~2007-09-15 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-15 21:53 Ben Taylor [this message]
2007-09-15 22:23 ` [Qemu-devel] Comment for Solaris fix for the HPTC Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2007-09-16 15:11 Ben Taylor
2007-09-16 16:35 ` Andreas Schwab
2007-09-16 17:18 ` Johannes Schindelin
2007-09-17 9:12 Juergen Keil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32504809.1189893234270.JavaMail.root@eastrmwml11 \
--to=sol10x86@cox.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).