From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IWfaP-0001gx-0C
	for qemu-devel@nongnu.org; Sat, 15 Sep 2007 17:53:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IWfaN-0001eP-Hy
	for qemu-devel@nongnu.org; Sat, 15 Sep 2007 17:53:56 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IWfaN-0001eJ-Dh
	for qemu-devel@nongnu.org; Sat, 15 Sep 2007 17:53:55 -0400
Received: from eastrmmtao102.cox.net ([68.230.240.8])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sol10x86@cox.net>) id 1IWfaN-0006pa-1R
	for qemu-devel@nongnu.org; Sat, 15 Sep 2007 17:53:55 -0400
Received: from eastrmimpo01.cox.net ([68.1.16.119]) by eastrmmtao102.cox.net
	(InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id
	<20070915215355.NXVN24118.eastrmmtao102.cox.net@eastrmimpo01.cox.net>
	for <qemu-devel@nongnu.org>; Sat, 15 Sep 2007 17:53:55 -0400
Message-ID: <32504809.1189893234270.JavaMail.root@eastrmwml11>
Date: Sat, 15 Sep 2007 17:53:54 -0400
From: Ben Taylor <sol10x86@cox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Comment for Solaris fix for the HPTC
Reply-To: sol10x86@cox.net, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


Compiling the latest CVS code, I found that a function in vl.c uses a define
called ULONG_LONG_MAX.  The value is defined in solaris's sys/types.h,
but only on _LP64 builds, so 32-bit builds won't pickup if I redefine it as 
ULONG_MAX.

I'm looking for comments on this patch.

--- qemu.ORIG/vl.h      2007-08-26 13:46:00.000000000 -0400
+++ qemu/vl.h   2007-09-15 17:59:24.179299000 -0400
@@ -49,6 +49,12 @@
 #define ENOMEDIUM ENODEV
 #endif

+#ifdef __sun__
+/* Have to define this for Solaris as ULONG_LONG_MAX is not defined
+   anywhere.  ULONG_MAX is correct only on _LP64 systems */
+#define ULONG_LONG_MAX 18446744073709551615UL
+#endif
+
 #ifdef _WIN32
 #include <windows.h>
 #define fsync _commit