qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH] win32: fix README file in NSIS installer
Date: Mon, 9 Sep 2019 15:17:00 +0200	[thread overview]
Message-ID: <325c24e1-60f0-15b6-0f61-3cb8a4a9acea@redhat.com> (raw)
In-Reply-To: <20190909130840.25117-1-pbonzini@redhat.com>

On 9/9/19 3:08 PM, Paolo Bonzini wrote:
> Adjust after the rST conversion and consequent renaming.
> 
> Fixes: 336a7451e8803c21a2da6e7d1eca8cfb8e8b219a
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qemu.nsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu.nsi b/qemu.nsi
> index d0df0f4e3a..da18438071 100644
> --- a/qemu.nsi
> +++ b/qemu.nsi
> @@ -119,7 +119,7 @@ Section "${PRODUCT} (required)"
>      File "${SRCDIR}\Changelog"
>      File "${SRCDIR}\COPYING"
>      File "${SRCDIR}\COPYING.LIB"
> -    File "${SRCDIR}\README"
> +    File "${SRCDIR}\README.rst"
>      File "${SRCDIR}\VERSION"
>  
>      File "${BINDIR}\*.bmp"
> 

Also:

-- >8 --
@@ -211,7 +211,7 @@ Section "Uninstall"
     Delete "$INSTDIR\Changelog"
     Delete "$INSTDIR\COPYING"
     Delete "$INSTDIR\COPYING.LIB"
-    Delete "$INSTDIR\README"
+    Delete "$INSTDIR\README.rst"
     Delete "$INSTDIR\VERSION"
     Delete "$INSTDIR\*.bmp"
     Delete "$INSTDIR\*.bin"
---

With the snippet amended:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  reply	other threads:[~2019-09-09 13:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 13:08 [Qemu-devel] [PATCH] win32: fix README file in NSIS installer Paolo Bonzini
2019-09-09 13:17 ` Philippe Mathieu-Daudé [this message]
2019-09-09 13:23   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=325c24e1-60f0-15b6-0f61-3cb8a4a9acea@redhat.com \
    --to=philmd@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).