Re: configure --without-default-features confusion

[Thomas Huth <thuth@redhat.com>]

On 08/07/2021 21.12, Cole Robinson wrote:
> Hi all,
> 
> I'm a bit confused about the intended scope of ./configure
> --without-default-features. When I try it here there's still lots of
> stuff enabled:
> 
> $ ./configure --without-default-features
>      ...
>      VNC support                  : YES
>      VNC SASL support             : YES
>      VNC JPEG support             : YES
>      VNC PNG support              : YES
>      brlapi support               : YES
>      vde support                  : NO
>      netmap support               : NO
>      Linux AIO support            : NO
>      Linux io_uring support       : YES
>      ATTR/XATTR support           : YES
>      RDMA support                 : NO
>      PVRDMA support               : NO
>      ...
> 
> So rdma/pvrdma, which I have libs for, are disabled, but brlapi, which I
> have libs for, is auto enabled. VNC is not dependent on any external
> libraries, but it's still enabled. Etc.
> 
> ...okay now that I poke at this a bit, the brlapi bit and most (but not
> all) other features are disabled if I fix this:
> 
>> diff --git a/configure b/configure
>> index 650d9c0735..a71ebe10ff 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5189,7 +5189,7 @@ if test "$skip_meson" = no; then
>>           -Ddocs=$docs -Dsphinx_build=$sphinx_build -Dinstall_blobs=$blobs \
>>           -Dvhost_user_blk_server=$vhost_user_blk_server -Dmultiprocess=$multiprocess \
>>           -Dfuse=$fuse -Dfuse_lseek=$fuse_lseek -Dguest_agent_msi=$guest_agent_msi -Dbpf=$bpf\
>> -        $(if test "$default_features" = no; then echo "-Dauto_features=disabled"; fi) \
>> +        $(if test "$default_feature" = no; then echo "-Dauto_features=disabled"; fi) \

Looks like you've found a bug... Could you please send this as a proper 
patch to the mailing list?

> But there's still a handful of things that are left enabled, for example
>   VNC, xen, vhost-vdpa, ...
> 
> Is the intention for this knob to be a 'disable everything'?

I guess yes, but I think it's still work in progress ... not every feature 
has been revisited since this switch has been introduced.

  Thomas