From: "Cédric Le Goater" <clg@kaod.org>
To: Jamin Lin <jamin_lin@aspeedtech.com>,
Peter Maydell <peter.maydell@linaro.org>,
Steven Lee <steven_lee@aspeedtech.com>,
Troy Lee <leetroy@gmail.com>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: <troy_lee@aspeedtech.com>, <kane_chen@aspeedtech.com>
Subject: Re: [SPAM] [PATCH v2 00/16] Introduce AspeedCoprocessor class and base implementation
Date: Thu, 9 Oct 2025 13:34:21 +0200 [thread overview]
Message-ID: <326472bf-4242-4d05-bca5-b0066b48c541@kaod.org> (raw)
In-Reply-To: <20251009023301.4085829-1-jamin_lin@aspeedtech.com>
Jamin,
On 10/9/25 04:32, Jamin Lin wrote:
> v1:
> 1. Remove AspeedSoCState dependency from aspeed_uart_first, aspeed_uart_last,
> aspeed_soc_uart_set_chr, aspeed_soc_cpu_type, aspeed_mmio_map,
> aspeed_mmio_map_unimplemented, aspeed_soc_get_irq, and
> aspeed_soc_uart_realize APIs.
> 2. Introduce AspeedCoprocessor class and base implementation
>
> v2:
> Fix the "make check" failure.
A part from patch 7, the changes look good.
Thanks,
C.
> Jamin Lin (16):
> hw/arm/aspeed: Remove AspeedSoCState dependency from
> aspeed_uart_first() API
> hw/arm/aspeed: Remove AspeedSoCClass dependency from
> aspeed_uart_last() API
> hw/arm/aspeed: Remove AspeedSoCState dependency from
> aspeed_soc_uart_set_chr() API
> hw/arm/aspeed: Remove AspeedSoCClass dependency from
> aspeed_soc_cpu_type() API
> hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_mmio_map()
> API
> hw/arm/aspeed: Remove AspeedSoCState dependency from
> aspeed_mmio_map_unimplemented() API
> hw/arm/aspeed: Remove AspeedSoCState dependency from
> aspeed_soc_get_irq() API
> hw/arm/aspeed: Remove AspeedSoCState dependency from
> aspeed_soc_uart_realize() API
> hw/arm/aspeed: Introduce AspeedCoprocessor class and base
> implementation
> hw/arm/aspeed_ast27x0-ssp: Make AST27x0 SSP inherit from
> AspeedCoprocessor instead of AspeedSoC
> hw/arm/aspeed_ast27x0-tsp: Make AST27x0 TSP inherit from
> AspeedCoprocessor instead of AspeedSoC
> hw/arm/aspeed_ast27x0-ssp: Change to use Aspeed27x0CoprocessorState
> hw/arm/aspeed_ast27x0-tsp: Change to use Aspeed27x0CoprocessorState
> hw/arm/aspeed_ast27x0-ssp: Rename type to
> TYPE_ASPEED27X0SSP_COPROCESSOR
> hw/arm/aspeed_ast27x0-tsp: Rename type to
> TYPE_ASPEED27X0TSP_COPROCESSOR
> hw/arm/aspeed_ast27x0-{ssp,tsp}: Fix coding style
>
> include/hw/arm/aspeed_coprocessor.h | 62 ++++++++++++++
> include/hw/arm/aspeed_soc.h | 51 ++++-------
> hw/arm/aspeed.c | 10 ++-
> hw/arm/aspeed_ast10x0.c | 92 ++++++++++++--------
> hw/arm/aspeed_ast2400.c | 97 ++++++++++++---------
> hw/arm/aspeed_ast2600.c | 126 +++++++++++++++++-----------
> hw/arm/aspeed_ast27x0-fc.c | 33 +++++---
> hw/arm/aspeed_ast27x0-ssp.c | 73 ++++++++--------
> hw/arm/aspeed_ast27x0-tsp.c | 73 ++++++++--------
> hw/arm/aspeed_ast27x0.c | 109 +++++++++++++-----------
> hw/arm/aspeed_coprocessor_common.c | 49 +++++++++++
> hw/arm/aspeed_soc_common.c | 63 +++++++-------
> hw/arm/fby35.c | 10 ++-
> hw/arm/meson.build | 7 +-
> 14 files changed, 524 insertions(+), 331 deletions(-)
> create mode 100644 include/hw/arm/aspeed_coprocessor.h
> create mode 100644 hw/arm/aspeed_coprocessor_common.c
>
prev parent reply other threads:[~2025-10-09 11:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 2:32 [PATCH v2 00/16] Introduce AspeedCoprocessor class and base implementation Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 01/16] hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_uart_first() API Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 02/16] hw/arm/aspeed: Remove AspeedSoCClass dependency from aspeed_uart_last() API Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 03/16] hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_soc_uart_set_chr() API Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 04/16] hw/arm/aspeed: Remove AspeedSoCClass dependency from aspeed_soc_cpu_type() API Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 05/16] hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_mmio_map() API Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 06/16] hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_mmio_map_unimplemented() API Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 07/16] hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_soc_get_irq() API Jamin Lin via
2025-10-09 11:29 ` [SPAM] " Cédric Le Goater
2025-10-13 1:36 ` Jamin Lin
2025-10-09 2:32 ` [PATCH v2 08/16] hw/arm/aspeed: Remove AspeedSoCState dependency from aspeed_soc_uart_realize() API Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 09/16] hw/arm/aspeed: Introduce AspeedCoprocessor class and base implementation Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 10/16] hw/arm/aspeed_ast27x0-ssp: Make AST27x0 SSP inherit from AspeedCoprocessor instead of AspeedSoC Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 11/16] hw/arm/aspeed_ast27x0-tsp: Make AST27x0 TSP " Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 12/16] hw/arm/aspeed_ast27x0-ssp: Change to use Aspeed27x0CoprocessorState Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 13/16] hw/arm/aspeed_ast27x0-tsp: " Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 14/16] hw/arm/aspeed_ast27x0-ssp: Rename type to TYPE_ASPEED27X0SSP_COPROCESSOR Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 15/16] hw/arm/aspeed_ast27x0-tsp: Rename type to TYPE_ASPEED27X0TSP_COPROCESSOR Jamin Lin via
2025-10-09 2:32 ` [PATCH v2 16/16] hw/arm/aspeed_ast27x0-{ssp,tsp}: Fix coding style Jamin Lin via
2025-10-09 11:34 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=326472bf-4242-4d05-bca5-b0066b48c541@kaod.org \
--to=clg@kaod.org \
--cc=andrew@codeconstruct.com.au \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).