From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
qemu-riscv@nongnu.org, qemu-s390x@nongnu.org
Subject: Re: [PATCH 20/24] tcg/i386: Add cf parameter to tcg_out_cmp
Date: Sat, 12 Aug 2023 10:21:33 -0700 [thread overview]
Message-ID: <3264dbe3-0c33-742c-5c5c-beedb57f5e84@linaro.org> (raw)
In-Reply-To: <6a116d10-5e01-30f8-fbd6-30c062fcccc5@linaro.org>
On 8/11/23 08:06, Richard Henderson wrote:
> Basically, test sets SZ flags, where cmp sets SZCO. I want to add an optimizaton using C,
> so "cmp 0,x" should not be silently replaced by "test x,x".
This patch can be dropped entirely.
TEST clears C (which cmp vs 0 would also do). I was mis-remembering INC/DEC which leave C
unchanged and thus uninitialized wrt the current operation.
r~
next prev parent reply other threads:[~2023-08-12 17:23 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 3:11 [PATCH for-8.2 00/24] tcg: Introduce negsetcond opcodes Richard Henderson
2023-08-08 3:11 ` [PATCH 01/24] " Richard Henderson
2023-08-10 16:12 ` Peter Maydell
2023-08-10 16:39 ` Richard Henderson
2023-08-08 3:11 ` [PATCH 02/24] tcg: Use tcg_gen_negsetcond_* Richard Henderson
2023-08-08 15:55 ` Peter Maydell
2023-08-08 16:04 ` Richard Henderson
2023-08-10 16:13 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 03/24] target/alpha: Use tcg_gen_movcond_i64 in gen_fold_mzero Richard Henderson
2023-08-10 16:19 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 04/24] target/arm: Use tcg_gen_negsetcond_* Richard Henderson
2023-08-10 16:22 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 05/24] target/m68k: " Richard Henderson
2023-08-10 16:24 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 06/24] target/openrisc: " Richard Henderson
2023-08-10 16:24 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 07/24] target/ppc: " Richard Henderson
2023-08-08 16:51 ` Daniel Henrique Barboza
2023-08-15 12:54 ` Nicholas Piggin
2023-08-08 3:11 ` [PATCH 08/24] target/sparc: Use tcg_gen_movcond_i64 in gen_edge Richard Henderson
2023-08-10 16:29 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 09/24] target/tricore: Replace gen_cond_w with tcg_gen_negsetcond_tl Richard Henderson
2023-08-08 15:42 ` Bastian Koppelmann
2023-08-08 3:11 ` [PATCH 10/24] tcg/ppc: Implement negsetcond_* Richard Henderson
2023-08-08 16:55 ` Daniel Henrique Barboza
2023-08-08 3:11 ` [PATCH 11/24] tcg/ppc: Use the Set Boolean Extension Richard Henderson
2023-08-08 16:56 ` Daniel Henrique Barboza
2023-08-15 13:16 ` Nicholas Piggin
2023-08-08 3:11 ` [PATCH 12/24] tcg/aarch64: Implement negsetcond_* Richard Henderson
2023-08-10 16:39 ` Peter Maydell
2023-08-10 16:55 ` Richard Henderson
2023-08-10 16:58 ` Peter Maydell
2023-08-10 17:01 ` Richard Henderson
2023-08-08 3:11 ` [PATCH 13/24] tcg/arm: Implement negsetcond_i32 Richard Henderson
2023-08-10 16:41 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 14/24] tcg/riscv: Implement negsetcond_* Richard Henderson
2023-08-08 16:47 ` Daniel Henrique Barboza
2023-08-08 3:11 ` [PATCH 15/24] tcg/s390x: " Richard Henderson
2023-08-08 3:11 ` [PATCH 16/24] tcg/sparc64: " Richard Henderson
2023-08-11 12:24 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 17/24] tcg/i386: Merge tcg_out_brcond{32,64} Richard Henderson
2023-08-11 10:20 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 18/24] tcg/i386: Merge tcg_out_setcond{32,64} Richard Henderson
2023-08-11 10:21 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 19/24] tcg/i386: Merge tcg_out_movcond{32,64} Richard Henderson
2023-08-11 10:22 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 20/24] tcg/i386: Add cf parameter to tcg_out_cmp Richard Henderson
2023-08-11 10:26 ` Peter Maydell
2023-08-11 10:45 ` Peter Maydell
2023-08-11 15:06 ` Richard Henderson
2023-08-12 17:21 ` Richard Henderson [this message]
2023-08-08 3:11 ` [PATCH 21/24] tcg/i386: Use CMP+SBB in tcg_out_setcond Richard Henderson
2023-08-11 12:07 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 22/24] tcg/i386: Clear dest first in tcg_out_setcond if possible Richard Henderson
2023-08-11 12:09 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 23/24] tcg/i386: Use shift in tcg_out_setcond Richard Henderson
2023-08-11 12:10 ` Peter Maydell
2023-08-08 3:11 ` [PATCH 24/24] tcg/i386: Implement negsetcond_* Richard Henderson
2023-08-11 12:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3264dbe3-0c33-742c-5c5c-beedb57f5e84@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).