qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Jiri Denemark <jdenemar@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386: add VMX features to named CPU models
Date: Wed, 20 Nov 2019 23:14:42 +0100	[thread overview]
Message-ID: <32679eab-e789-1c43-565c-e783baf6591e@redhat.com> (raw)
In-Reply-To: <20191120211526.GW3812@habkost.net>

On 20/11/19 22:15, Eduardo Habkost wrote:
> 
> For how long was this broken?  Jiri, was libvirt including +vmx
> in mode=host-model for a long time, or is this something recent?

Could that be related to making nested=1 the default in the kernel?  KVM has

static void vmx_set_supported_cpuid(u32 func, struct kvm_cpuid_entry2
*entry)
{
        if (func == 1 && nested)
                entry->ecx |= bit(X86_FEATURE_VMX);
}

which would date the change to Linux 4.20 (December 2018).

Paolo



      reply	other threads:[~2019-11-20 22:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 17:37 [PATCH] target/i386: add VMX features to named CPU models Paolo Bonzini
2019-11-20 17:50 ` Daniel P. Berrangé
2019-11-20 17:57   ` Paolo Bonzini
2019-11-20 18:02     ` Daniel P. Berrangé
2019-11-20 18:16     ` Kashyap Chamarthy
2019-11-20 18:45 ` Eduardo Habkost
2019-11-20 20:49   ` Paolo Bonzini
2019-11-20 21:15     ` Eduardo Habkost
2019-11-20 22:14       ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32679eab-e789-1c43-565c-e783baf6591e@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jdenemar@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).