Re: [PATCH v1] s390x/tcg: Fix m5 vs. m4 field for VECTOR MULTIPLY SUM LOGICAL

[Thomas Huth <thuth@redhat.com>]

On 05/07/2021 11.03, David Hildenbrand wrote:
> The element size is located in m5, not in m4. As there is no m4, qemu
> currently crashes with an assertion, trying to lookup that field.
> 
> Reproduced and tested via GO, which ends up using VMSL once the
> Vector enhancements facility is around for verifying certificates with
> elliptic curves.
> 
> Reported-by: Jonathan Albrecht <jonathan.albrecht@linux.vnet.ibm.com>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/449
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>   target/s390x/translate_vx.c.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/s390x/translate_vx.c.inc b/target/s390x/translate_vx.c.inc
> index a9d51b1f4c..0afa46e463 100644
> --- a/target/s390x/translate_vx.c.inc
> +++ b/target/s390x/translate_vx.c.inc
> @@ -1783,7 +1783,7 @@ static DisasJumpType op_vmsl(DisasContext *s, DisasOps *o)
>   {
>       TCGv_i64 l1, h1, l2, h2;
>   
> -    if (get_field(s, m4) != ES_64) {
> +    if (get_field(s, m5) != ES_64) {
>           gen_program_exception(s, PGM_SPECIFICATION);
>           return DISAS_NORETURN;
>       }

Looks right.

Reviewed-by: Thomas Huth <thuth@redhat.com>