From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B63C07E98 for ; Mon, 5 Jul 2021 09:35:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F68061357 for ; Mon, 5 Jul 2021 09:35:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F68061357 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0L0u-0006rP-Em for qemu-devel@archiver.kernel.org; Mon, 05 Jul 2021 05:35:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0Kz4-0005Hr-Ur for qemu-devel@nongnu.org; Mon, 05 Jul 2021 05:33:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0Kz3-00045d-G0 for qemu-devel@nongnu.org; Mon, 05 Jul 2021 05:33:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625477624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F13z4RKpfmbFGA0W6p8rYIem5hbXHw/Nn8rHddkdZI0=; b=C8Y39BTN4kd4urx9XgK6AhLTkcu4VQzYbyI8KgcR0MtixJrjmMwY7F6/OPAg0iNZ6JYisD DyR+KFrcvarhQOxGf/RI9DvtW3lbWG4yttFTJ3yrLkRFAgNvkv+oamxYuyedlIZ2LJh1UY xI0/Eq9WHyBVLu3n3DdelPh8DFPcctY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-GUuEXFWaMtGiy-K7jqPw-A-1; Mon, 05 Jul 2021 05:33:43 -0400 X-MC-Unique: GUuEXFWaMtGiy-K7jqPw-A-1 Received: by mail-wr1-f72.google.com with SMTP id a4-20020adffb840000b02901304c660e75so2839161wrr.19 for ; Mon, 05 Jul 2021 02:33:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F13z4RKpfmbFGA0W6p8rYIem5hbXHw/Nn8rHddkdZI0=; b=KwwdBOUezPpvz2Q1D31BZSSGhPlPvNeOQSC/jaoeOQzPUkB5VwTWO+MohPwsflZQAj UWBj3txpKoe6+GTv+SXTFDB7bCe2AlMOrMdAu7VKY12Y/VrdD0QeRw7ckNGZ3gp9S5uF AdZG/zmiWKpbMVTb19eGgKy585Xv3Ch5MwDJjO+IwEB/0Y/ZRaiZp1caX1zA6sLcCyyN MHST+RX6hq5U8zOSgtLjJhkAcpHXLksnylOmVymz80AhwJbRb3RrS43iYL7TVK2zOXkP 2nwLZIHPLQJIg2xtfo6mo0nb2yeUQ55SNDJXq9Vc44lMH4dugCHgTBJy6wSyhIzGIZCr eFKw== X-Gm-Message-State: AOAM533dybsfM4KS/b1FF4M4NyJQIU6WhQ/jNjR/um30CTuohrK7/g/Z jUtp3n/t1wSdj1CzVVMnYCdGfyOvE6qANcFQmV46wt2JGhvokaa3vf8FYRne5CweG2mxXB5Lmyr +11JTSrSfHcHJIyA= X-Received: by 2002:a1c:f70d:: with SMTP id v13mr13253236wmh.183.1625477622373; Mon, 05 Jul 2021 02:33:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaV18QdHRfZdbFYfNXvyLZwmlQ6jk9S9N+39XnGhS16OuZBuKoJlMSvjj2m0qcd19D7bDBAw== X-Received: by 2002:a1c:f70d:: with SMTP id v13mr13253212wmh.183.1625477622105; Mon, 05 Jul 2021 02:33:42 -0700 (PDT) Received: from thuth.remote.csb (pd9575e1e.dip0.t-ipconnect.de. [217.87.94.30]) by smtp.gmail.com with ESMTPSA id m12sm11356421wms.24.2021.07.05.02.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jul 2021 02:33:41 -0700 (PDT) Subject: Re: [PATCH v1] s390x/tcg: Fix m5 vs. m4 field for VECTOR MULTIPLY SUM LOGICAL To: David Hildenbrand , qemu-devel@nongnu.org References: <20210705090341.58289-1-david@redhat.com> From: Thomas Huth Message-ID: <32680adc-edb8-a24c-a4eb-ae9bb4de1451@redhat.com> Date: Mon, 5 Jul 2021 11:33:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210705090341.58289-1-david@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.441, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Cornelia Huck , Richard Henderson , Jonathan Albrecht Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 05/07/2021 11.03, David Hildenbrand wrote: > The element size is located in m5, not in m4. As there is no m4, qemu > currently crashes with an assertion, trying to lookup that field. > > Reproduced and tested via GO, which ends up using VMSL once the > Vector enhancements facility is around for verifying certificates with > elliptic curves. > > Reported-by: Jonathan Albrecht > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/449 > Signed-off-by: David Hildenbrand > --- > target/s390x/translate_vx.c.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/translate_vx.c.inc b/target/s390x/translate_vx.c.inc > index a9d51b1f4c..0afa46e463 100644 > --- a/target/s390x/translate_vx.c.inc > +++ b/target/s390x/translate_vx.c.inc > @@ -1783,7 +1783,7 @@ static DisasJumpType op_vmsl(DisasContext *s, DisasOps *o) > { > TCGv_i64 l1, h1, l2, h2; > > - if (get_field(s, m4) != ES_64) { > + if (get_field(s, m5) != ES_64) { > gen_program_exception(s, PGM_SPECIFICATION); > return DISAS_NORETURN; > } Looks right. Reviewed-by: Thomas Huth