From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bkXg7-0003b4-Qs
	for qemu-devel@nongnu.org; Thu, 15 Sep 2016 10:30:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bkXfz-000481-8A
	for qemu-devel@nongnu.org; Thu, 15 Sep 2016 10:30:10 -0400
Received: from mail-qt0-f179.google.com ([209.85.216.179]:36054)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bkXfz-00047h-4w
	for qemu-devel@nongnu.org; Thu, 15 Sep 2016 10:30:07 -0400
Received: by mail-qt0-f179.google.com with SMTP id l91so26017013qte.3
	for <qemu-devel@nongnu.org>; Thu, 15 Sep 2016 07:30:07 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1473707034-31147-1-git-send-email-dgilbert@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <326824ce-113c-3314-94e8-fca272444306@redhat.com>
Date: Thu, 15 Sep 2016 16:28:59 +0200
MIME-Version: 1.0
In-Reply-To: <1473707034-31147-1-git-send-email-dgilbert@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] migration: Fix seg with missing port
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>, qemu-devel@nongnu.org, berrange@redhat.com, quintela@redhat.com, amit.shah@redhat.com



On 12/09/2016 21:03, Dr. David Alan Gilbert (git) wrote:
>      SocketAddress *saddr = tcp_build_address(host_port, errp);
> -    socket_start_outgoing_migration(s, saddr, errp);
> +    if (!*errp) {
> +        socket_start_outgoing_migration(s, saddr, errp);
> +    }
>  }
>  
>  void unix_start_outgoing_migration(MigrationState *s,
> @@ -175,7 +177,9 @@ static void socket_start_incoming_migration(SocketAddress *saddr,
>  void tcp_start_incoming_migration(const char *host_port, Error **errp)
>  {
>      SocketAddress *saddr = tcp_build_address(host_port, errp);
> -    socket_start_incoming_migration(saddr, errp);
> +    if (!*errp) {
> +        socket_start_incoming_migration(saddr, errp);
> +    }

FWIW, this less-boilerplate version was almost fine, just replace
"!*errp" with "saddr".

Paolo