From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dB3fn-0003U0-B7 for qemu-devel@nongnu.org; Wed, 17 May 2017 14:27:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dB3fm-0000Xm-1t for qemu-devel@nongnu.org; Wed, 17 May 2017 14:27:47 -0400 References: <684185116.2952708.1495044580181.ref@mail.yahoo.com> <684185116.2952708.1495044580181@mail.yahoo.com> From: Eric Blake Message-ID: <3293e70a-71ac-2e6d-433f-06346ad253c9@redhat.com> Date: Wed, 17 May 2017 13:27:37 -0500 MIME-Version: 1.0 In-Reply-To: <684185116.2952708.1495044580181@mail.yahoo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uJjXCVmMx1Cf3e0aVdCPKVgv5KENaO4Jd" Subject: Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Bradley , "qemu-devel@nongnu.org" Cc: John Bradley , Laurent Vivier , Peter Maydell , Geert Martin Ijewski , Markus Armbruster , Alistair Francis , "qemu-arm@nongnu.org" , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uJjXCVmMx1Cf3e0aVdCPKVgv5KENaO4Jd From: Eric Blake To: John Bradley , "qemu-devel@nongnu.org" Cc: John Bradley , Laurent Vivier , Peter Maydell , Geert Martin Ijewski , Markus Armbruster , Alistair Francis , "qemu-arm@nongnu.org" , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <3293e70a-71ac-2e6d-433f-06346ad253c9@redhat.com> Subject: Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM. References: <684185116.2952708.1495044580181.ref@mail.yahoo.com> <684185116.2952708.1495044580181@mail.yahoo.com> In-Reply-To: <684185116.2952708.1495044580181@mail.yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/17/2017 01:09 PM, John Bradley via Qemu-devel wrote: > Also available at=20 >=20 > https://www.dropbox.com/s/gwuquw0kirstw7a/0001-Add-Markus-Armbrusters-c= ode-for-Broadcom-Perhiperals.patch?dl=3D0 This content belongs... >=20 > Following suggestions split my original patch up. This the largest mono= lithic chunk is=20 > additional BCM device support from Markus Armbruster. >=20 >=20 >>>From 0b39a04030d5a2cea4fcd2159d365580ca155b78 Mon Sep 17 00:00:00 2001 > From: John Bradley > Date: Wed, 17 May 2017 18:57:21 +0100 > Subject: [PATCH] Add Markus Armbrusters code for Broadcom Perhiperals f= or ARM. >=20 > Signed-off-by: John Bradley I would expect that if some of this code was written by Markus, then it would carry his Signed-off-by. Or, maybe you just mean that you are splitting your patch according to the device Markus gave (in which case, a Suggested-by: tag may be appropriate). Either way, I don't see why Markus' name has to be in the subject line (the patch subject should be WHAT changed, not WHO suggested the change). > --- =2E..here, after the --- separator. It is useful to reviewers, but shoul= d not end up as part of the actual commit message. > hw/arm/Makefile.objs | 2 +- > hw/arm/bcm2835.c | 114 ++++ > hw/arm/bcm2835_peripherals.c | 104 ++++ > hw/misc/Makefile.objs | 2 + > hw/misc/bcm2835_mphi.c | 163 ++++++ > hw/misc/bcm2835_power.c | 106 ++++ > hw/timer/Makefile.objs | 2 + > hw/timer/bcm2835_st.c | 202 +++++++ > hw/timer/bcm2835_timer.c | 224 +++++++ > hw/usb/Makefile.objs | 4 +- > hw/usb/bcm2835_usb.c | 604 +++++++++++++++++++ > hw/usb/bcm2835_usb_regs.h | 1061 +++++++++++++++++++++++++++= +++++++ That's still rather large to review in one chunk, especially while touching other files. It can probably still be split up further. > include/hw/arm/bcm2835.h | 37 ++ > include/hw/arm/bcm2835_peripherals.h | 10 + > include/hw/intc/bcm2835_control.h | 53 ++ > include/hw/misc/bcm2835_mphi.h | 28 + > include/hw/misc/bcm2835_power.h | 22 + > include/hw/timer/bcm2835_st.h | 25 + > include/hw/timer/bcm2835_timer.h | 32 + > include/hw/usb/bcm2835_usb.h | 78 +++ > 20 files changed, 2871 insertions(+), 2 deletions(-) > create mode 100644 hw/arm/bcm2835.c > create mode 100644 hw/misc/bcm2835_mphi.c > create mode 100644 hw/misc/bcm2835_power.c > create mode 100644 hw/timer/bcm2835_st.c > create mode 100644 hw/timer/bcm2835_timer.c > create mode 100644 hw/usb/bcm2835_usb.c > create mode 100644 hw/usb/bcm2835_usb_regs.h > create mode 100644 include/hw/arm/bcm2835.h > create mode 100644 include/hw/intc/bcm2835_control.h > create mode 100644 include/hw/misc/bcm2835_mphi.h > create mode 100644 include/hw/misc/bcm2835_power.h > create mode 100644 include/hw/timer/bcm2835_st.h > create mode 100644 include/hw/timer/bcm2835_timer.h > create mode 100644 include/hw/usb/bcm2835_usb.h >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --uJjXCVmMx1Cf3e0aVdCPKVgv5KENaO4Jd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJZHJYZAAoJEKeha0olJ0NqnQgH/A8PYV3U6M2X8nxgSdQAvtFQ BIYo+cTVJ0Zpi9Cds50OvfGJat1qyVH1K3Dj/JFpOdRf+rvenzccnyNMuFp24VgE nnnk00Scki+JmdFA8lyWTpzdNJGEXstWyW1+iErJh+kXjhPnkIl/LeahVQBPTV6i xHtaQy0IjXMps3jRR4kH9kOGceQaFtE2FyFom5sSpagvXk7CGerXoCwmhQpfB97v hcF1b7II23M6DGgu/A4kQgpQADN6jk/NmYOIhVcZj8O18SohFyM26/uzMLpLWYkk PxSrs3tK7Srh+8dkttqTCEFrd6Zi1Aj73bbHo0W51IOXFw8yTSESmd5T9z1/Edk= =T771 -----END PGP SIGNATURE----- --uJjXCVmMx1Cf3e0aVdCPKVgv5KENaO4Jd--