qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Subject: Re: [PATCH 1/2] iotests: add JobRunner class
Date: Tue, 3 Mar 2020 16:32:46 -0500	[thread overview]
Message-ID: <3293faba-9462-00e3-9bda-7e4c05d004ba@redhat.com> (raw)
In-Reply-To: <8b6281dd-c218-1cdb-6370-f49e8d92a4d8@redhat.com>



On 2/27/20 6:44 AM, Max Reitz wrote:
>> I'll just clean up the logging series I had to do it at a more
>> fundamental level.
> OK.  So you’re looking to basically get VM.qmp() to log automatically if
> necessary?  (or maybe qmp_log() to not log unless necessary)
> 
> Max
> 

Yes. If this series looks good I will just rebase it on top of the
logging series. Then self.logging goes away and the calls to qmp_log et
al just become unconditional.

Then we can enable/disable "all QMP logging" globally instead of
individually throughout the iotests shared codebase.

--js



  reply	other threads:[~2020-03-03 21:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  0:44 [PATCH 0/2] iotests: complicate run_job with this one weird trick? John Snow
2020-02-26  0:44 ` [PATCH 1/2] iotests: add JobRunner class John Snow
2020-02-26 11:18   ` Max Reitz
2020-02-26 17:58     ` John Snow
2020-02-27 11:44       ` Max Reitz
2020-03-03 21:32         ` John Snow [this message]
2020-02-26  0:44 ` [PATCH 2/2] iotests: modify test 040 to use JobRunner John Snow
2020-02-26 11:31   ` Max Reitz
2020-02-26 18:04     ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3293faba-9462-00e3-9bda-7e4c05d004ba@redhat.com \
    --to=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).