From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB2EC38A30 for ; Wed, 22 Apr 2020 04:14:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0672A206D5 for ; Wed, 22 Apr 2020 04:14:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uqoU5xOs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0672A206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jR6mZ-00082Z-7t for qemu-devel@archiver.kernel.org; Wed, 22 Apr 2020 00:14:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52648) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jR6lK-0007bq-IC for qemu-devel@nongnu.org; Wed, 22 Apr 2020 00:13:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jR6lI-0005RJ-Fo for qemu-devel@nongnu.org; Wed, 22 Apr 2020 00:13:24 -0400 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:50575) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jR6lH-0004xK-T2 for qemu-devel@nongnu.org; Wed, 22 Apr 2020 00:13:24 -0400 Received: by mail-pj1-x1044.google.com with SMTP id t9so334554pjw.0 for ; Tue, 21 Apr 2020 21:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QS3Gwqb+cA2Y4B6bPxybgl4EXvBvpjVilRCCI7CC0+o=; b=uqoU5xOsMSyT+JAn5HT64zaL4csqP+qdXIlqG5S6PGoOMm+k89Wea4ORl+xQskRuEd t4S1r5z7wObeeZ4NmRuxqZiuIPKZni5vKsFIUXYgVUGrUoFodBlFfrStvNrf04E4630i lw4VM3WcYJZjb6mxJkR4mwz7w34oZZX3rpFOdQa31f+brCUD0iopI3pN2znZjh5TsMYS op69GT9U3OBLX1SQa0RAZUUCT27Ix/Z9DdRQWnZIeu0AVZ5NVar7EHeYtanW+vVjaGWZ 0VHozpYjKbSqQZiNJdZZPjDs/dEXY8OIZt+CHg0sxaBZwHDW40F+DGQjidg7Zy3JWC4j Bh6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QS3Gwqb+cA2Y4B6bPxybgl4EXvBvpjVilRCCI7CC0+o=; b=Oa/7g12su949i6HgPN6bCY03tL6pksXMok5lysYPJnYm/ZlGopmUyE6fSiHc4ocaEB eK4RfEKfVgaJcPvrU2ygmHmJQbobJELU0Tdyj523dFc6dY1Ci1nB+yQfzpzBGslTX+O5 0tAb+DEuGwQlGrJxuq+EeLoUTAP7n40LV59DH58r/5MIWp83krY7iwNMW/89eT6XGb/U ERIMtQ3av8UgKErk/BUeJQLxLZsKHnB3WlkDY0F1Clijlwzk7N7nyjguZ94t9gdm1j1g PIJBha6/1Dp+256LIpIf8EcFwYcxw2pHUH/0+XmwQC/oC+UZ46i8yk1CWLENf9E5lLJH S9nQ== X-Gm-Message-State: AGi0PuZa5qePw4eyxrgW+sVCypRguLJEvhhL67ibTn1bEmUYoLsqy2xG vSGvC1j92PyDR4ms4BSn6sE4wl2ZwpM= X-Google-Smtp-Source: APiQypJdrtZe6rn0fZtRLEz4TlmHvXuEg6JcdKs53TFFNEN3LoAPAIQwSePVS2ATN2x3biuK6KHwlA== X-Received: by 2002:a17:90b:3d2:: with SMTP id go18mr9615587pjb.142.1587528801303; Tue, 21 Apr 2020 21:13:21 -0700 (PDT) Received: from [192.168.1.11] (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id y21sm4002404pfm.219.2020.04.21.21.13.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2020 21:13:20 -0700 (PDT) Subject: Re: [PATCH 1/6] target/arm: Restric the Address Translate write operation to TCG accel To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200421131926.12116-1-philmd@redhat.com> <20200421131926.12116-2-philmd@redhat.com> From: Richard Henderson Message-ID: <32b0de3d-cc23-1758-f9b2-e51234706a2f@linaro.org> Date: Tue, 21 Apr 2020 21:13:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200421131926.12116-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1044; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1044.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2607:f8b0:4864:20::1044 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/21/20 6:19 AM, Philippe Mathieu-Daudé wrote: > Under KVM these registers are written by the hardware. > Restrict the writefn handlers to TCG to avoid when building > without TCG: > > LINK aarch64-softmmu/qemu-system-aarch64 > target/arm/helper.o: In function `do_ats_write': > target/arm/helper.c:3524: undefined reference to `raise_exception' > > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > Better explanation: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg689388.html > --- > target/arm/helper.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) Reviewed-by: Richard Henderson r~