Re: [Qemu-devel] [PATCH v5 03/10] docs: VM Generation ID device description

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]

On 02/05/2017 03:11 AM, ben@skyportsystems.com wrote:
> From: Ben Warren <ben@skyportsystems.com>
> 
> This patch is based off an earlier version by
> Gal Hammer (ghammer@redhat.com)
> 
> Requirements section, ASCII diagrams and overall help
> provided by Laszlo Ersek (lersek@redhat.com)
> 
> Signed-off-by: Gal Hammer <ghammer@redhat.com>
> Signed-off-by: Ben Warren <ben@skyportsystems.com>
> ---
>  docs/specs/vmgenid.txt | 239 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 239 insertions(+)
>  create mode 100644 docs/specs/vmgenid.txt
> 

> +

> +
> +Design Details:
> +---------------
> +
> +Requirements R1a through R1e dicate that the memory holding the

s/dicate/dictate/

> +VM Generation ID must be allocated and owned by the guest operating system,

> +
> +GUID Storage Format:
> +--------------------
> +
> +In order to work with OVMF "SDT Header Probe Supressor", the contents of

s/Supressor/Suppressor/

> +the vmgenid fw_cfg blob are not simply a 128-bit GUID.  There is also
> +significant padding in order to align and fill a memory page, as shown in the
> +following diagram:
> +
> ++----------------------------------+
> +| SSDT with OEM Table ID = VMGENID |
> ++----------------------------------+
> +| ...                              |       TOP OF PAGE
> +| VGIA dword object ---------------|-----> +---------------------------+
> +| ...                              |       | fw-allocated array for    |
> +| _STA method referring to VGIA    |       | "etc/vmgenid"        |

Inconsistent whitespace

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]