From: Paolo Bonzini <pbonzini@redhat.com>
To: Peng Hao <peng.hao2@zte.com.cn>,
rkrcmar@redhat.com, mst@redhat.com, ehabkost@redhat.com
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH V6 3/5] target-i386: add rtc 0x70 port as coalesced_pio
Date: Wed, 17 Oct 2018 12:31:39 +0200 [thread overview]
Message-ID: <32bbd4a7-94eb-1f0a-7f2f-d59d5e47dda6@redhat.com> (raw)
In-Reply-To: <1539795177-21038-4-git-send-email-peng.hao2@zte.com.cn>
On 17/10/2018 18:52, Peng Hao wrote:
> + /* register rtc 0x70 port as coalesced_pio */
> + memory_region_set_flush_coalesced(&s->io);
> + memory_region_init_io(&s->coalesced_io, OBJECT(s), &cmos_ops,
> + s, "rtc1", 1);
> + isa_register_ioport(isadev, &s->coalesced_io, base);
I think instead of isa_register_ioport you can use
memory_region_add_subregion, so that s->coalesced_io is added below s->io?
This way, you don't rely on the behavior of overlapping regions.
Paolo
> + memory_region_add_coalescing(&s->coalesced_io, 0, 1);
> +
next prev parent reply other threads:[~2018-10-17 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 16:52 [Qemu-devel] [PATCH 0/5] target/i386: introduce coalesced pio Peng Hao
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 1/5] target/i386 : add coalesced pio support Peng Hao
2018-10-17 15:04 ` Vitaly Kuznetsov
2018-10-17 17:05 ` Paolo Bonzini
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 2/5] target-i386 : add coalesced_pio API Peng Hao
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 3/5] target-i386: add rtc 0x70 port as coalesced_pio Peng Hao
2018-10-17 10:31 ` Paolo Bonzini [this message]
2018-10-18 8:03 ` peng.hao2
2018-10-18 10:13 ` Paolo Bonzini
2018-10-18 10:43 ` peng.hao2
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 4/5] target-i386: add i440fx 0xcf8 " Peng Hao
2018-10-17 16:52 ` [Qemu-devel] [PATCH V6 5/5] target-i386: add q35 " Peng Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32bbd4a7-94eb-1f0a-7f2f-d59d5e47dda6@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=peng.hao2@zte.com.cn \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).