qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	devel@lists.libvirt.org,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	qemu-ppc@nongnu.org, "Zhao Liu" <zhao1.liu@intel.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	qemu-s390x@nongnu.org, "Alexandre Iooss" <erdnaxe@crans.org>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH 12/17] tests/tcg: ensure s390x-softmmu output redirected
Date: Mon, 16 Sep 2024 07:27:56 +0200	[thread overview]
Message-ID: <32e9207b-0aac-4d43-9dbf-bf5e36d634de@redhat.com> (raw)
In-Reply-To: <20240913172655.173873-13-alex.bennee@linaro.org>

On 13/09/2024 19.26, Alex Bennée wrote:
> The multiarch system tests output serial data which should be
> redirected to the "output" chardev rather than echoed to the console.
> 
> Remove the unused EXTFLAGS variable while we are at it.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/tcg/s390x/Makefile.softmmu-target | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target
> index f60f94b090..ad681bbe40 100644
> --- a/tests/tcg/s390x/Makefile.softmmu-target
> +++ b/tests/tcg/s390x/Makefile.softmmu-target
> @@ -1,6 +1,6 @@
>   S390X_SRC=$(SRC_PATH)/tests/tcg/s390x
>   VPATH+=$(S390X_SRC)
> -QEMU_OPTS+=-action panic=exit-failure -nographic $(EXTFLAGS) -kernel
> +QEMU_OPTS+=-action panic=exit-failure -nographic -serial chardev:output -kernel
>   LINK_SCRIPT=$(S390X_SRC)/softmmu.ld
>   CFLAGS+=-ggdb -O0
>   LDFLAGS=-nostdlib -static

EXTFLAGS has been added on purpose here, see commit 26a09ead7351f117ae780.

  Thomas



  reply	other threads:[~2024-09-16  5:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 17:26 [PATCH 00/17] tcg plugins pre-PR (deprecations, mem apis, contrib plugins) Alex Bennée
2024-09-13 17:26 ` [PATCH 01/17] deprecation: don't enable TCG plugins by default on 32 bit hosts Alex Bennée
2024-09-13 17:26 ` [PATCH 02/17] deprecation: don't enable TCG plugins by default with TCI Alex Bennée
2024-09-13 17:26 ` [PATCH 03/17] contrib/plugins: control flow plugin Alex Bennée
2024-09-13 17:26 ` [PATCH 04/17] plugins: save value during memory accesses Alex Bennée
2024-09-13 17:26 ` [PATCH 05/17] plugins: extend API to get latest memory value accessed Alex Bennée
2024-09-13 17:26 ` [PATCH 06/17] tests/tcg: add mechanism to run specific tests with plugins Alex Bennée
2024-09-13 17:26 ` [PATCH 07/17] tests/tcg: allow to check output of plugins Alex Bennée
2024-09-13 17:26 ` [PATCH 08/17] tests/tcg/plugins/mem: add option to print memory accesses Alex Bennée
2024-09-13 17:26 ` [PATCH 09/17] tests/tcg/multiarch: add test for plugin memory access Alex Bennée
2024-09-13 17:26 ` [PATCH 10/17] tests/tcg: clean up output of memory system test Alex Bennée
2024-09-13 17:26 ` [PATCH 11/17] tests/tcg: only read/write 64 bit words on 64 bit systems Alex Bennée
2024-09-13 20:15   ` Philippe Mathieu-Daudé
2024-09-16  8:41     ` Alex Bennée
2024-09-13 17:26 ` [PATCH 12/17] tests/tcg: ensure s390x-softmmu output redirected Alex Bennée
2024-09-16  5:27   ` Thomas Huth [this message]
2024-09-16  8:37     ` Alex Bennée
2024-09-13 17:26 ` [PATCH 13/17] tests/tcg: add a system test to check memory instrumentation Alex Bennée
2024-09-13 17:26 ` [PATCH 14/17] util/timer: avoid deadlock when shutting down Alex Bennée
2024-09-13 17:26 ` [PATCH 15/17] contrib/plugins: Add a plugin to generate basic block vectors Alex Bennée
2024-09-13 17:26 ` [PATCH 16/17] plugins: add plugin API to read guest memory Alex Bennée
2024-09-13 20:17   ` Philippe Mathieu-Daudé
2024-09-13 17:26 ` [PATCH 17/17] plugins: add option to dump write argument to syscall plugin Alex Bennée
2024-09-13 20:18   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32e9207b-0aac-4d43-9dbf-bf5e36d634de@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=danielhb413@gmail.com \
    --cc=david@redhat.com \
    --cc=devel@lists.libvirt.org \
    --cc=eduardo@habkost.net \
    --cc=erdnaxe@crans.org \
    --cc=iii@linux.ibm.com \
    --cc=ma.mandourr@gmail.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=wangyanan55@huawei.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).