From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0C6C433E0 for ; Tue, 16 Jun 2020 13:24:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 279CD2098B for ; Tue, 16 Jun 2020 13:24:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ESJV2+cG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 279CD2098B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlBZw-0004fT-Bm for qemu-devel@archiver.kernel.org; Tue, 16 Jun 2020 09:24:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlBZ7-0003Mk-30 for qemu-devel@nongnu.org; Tue, 16 Jun 2020 09:23:49 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:49170 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jlBZ5-0005jY-FM for qemu-devel@nongnu.org; Tue, 16 Jun 2020 09:23:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592313826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E8W7Qlc2zMVsN2JgnK/qH4Jp0+pTA8BG4yaaIzGy8Kc=; b=ESJV2+cG0ccXBHrdGqEmxcmn7wDvChUkk7csoviIloNXUfXyV2wen1L5I/B5rDu9X4cAnp 7l8EeaWSd1bPn4iKTVzrsRB8sj7oUtEcT8HxrrYAAlsc9WOpQvhmMdc3qYkBVyS6ok8Wl/ OYsfbMTuXzWMEYqCq3u56MYPK5omg6M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-498-skgAieidMCSOuTAlWVotiQ-1; Tue, 16 Jun 2020 09:23:41 -0400 X-MC-Unique: skgAieidMCSOuTAlWVotiQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7CFAE80332A; Tue, 16 Jun 2020 13:23:40 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-112-244.ams2.redhat.com [10.36.112.244]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22B3D5C1BD; Tue, 16 Jun 2020 13:23:35 +0000 (UTC) Subject: Re: [PATCH v8 05/14] block/amend: refactor qcow2 amend options To: Maxim Levitsky , qemu-devel@nongnu.org References: <20200608094030.670121-1-mlevitsk@redhat.com> <20200608094030.670121-6-mlevitsk@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <32faa102-737e-320e-fe7a-501965719f07@redhat.com> Date: Tue, 16 Jun 2020 15:23:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200608094030.670121-6-mlevitsk@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="utuSUox89lCUP0o7Jqqg0nnTCiGu4624w" Received-SPF: pass client-ip=205.139.110.120; envelope-from=mreitz@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/16 02:45:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-block@nongnu.org, Markus Armbruster , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --utuSUox89lCUP0o7Jqqg0nnTCiGu4624w Content-Type: multipart/mixed; boundary="XmcetxVK66BbJEBLJ3UwwreuQDcTUSx4K" --XmcetxVK66BbJEBLJ3UwwreuQDcTUSx4K Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 08.06.20 11:40, Maxim Levitsky wrote: > Some qcow2 create options can't be used for amend. > Remove them from the qcow2 create options and add generic logic to detect > such options in qemu-img >=20 > Signed-off-by: Maxim Levitsky > Reviewed-by: Daniel P. Berrang=C3=A9 Last week (when I was about to prepare a pull request), I noticed that this patch breaks the iotests 134 and 158 for qcow (v1). That=E2=80=99s be= cause as of this patch, qcow2 has a different order of creation options than qcow= . We could easily fix this by moving HEAD^:134.out and HEAD^:158.out to 134.out.qcow and 158.out.qcow, respectively, and HEAD:134.out and HEAD:158.out to 134.out.qcow2 and 158.out.qcow2, respectively. But the underlying problem is a greater one: The order of creation options isn=E2=80=99t fixed between different formats, so I think _filter_img_create should sort it so it=E2=80=99s the same for all. To do so, I just sent the =E2=80=9Ciotests: Make _filter_img_create more ac= tive=E2=80=9D series. We could put that underneath your series and then the problem would be fixed, too (and we could drop some of the hunks from this patch, because the option order wouldn=E2=80=99t change for any test that u= ses _filter_img_create). Max --XmcetxVK66BbJEBLJ3UwwreuQDcTUSx4K-- --utuSUox89lCUP0o7Jqqg0nnTCiGu4624w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl7ox9YACgkQ9AfbAGHV z0BEkggAt3cYkBojZOG7zz9FvsRNECbzxnw1fgIiLvIUx/KhdgYWZTLCGMNg2dUJ 9UhN3QGdChqnjbDVkDRgiyMQLuUn2pMRHnnNbw8tEgzV/9iKsnjqWKTCEd0DX/Vy 3Xf9GqB2/bdolTE7n045h/+ZGERT/00afLuUT4aJ5AUWYF38dmiWT5kwZV7SyA5R b2m/qvV1aw2Gcpy0Q66wiQmWOg9xZfL/8QsECOpOiTWx7XSmMxgjgKSIYSJECR7A v4qTrXkcXqZILMHUFBT+C4A0X8hDd9Euq83CBaNdARrCayY0VLEdBVKXUHz4aNVT sPa3CkNJgKvwx0HgyO0XtpFTGZJYlg== =B1Zr -----END PGP SIGNATURE----- --utuSUox89lCUP0o7Jqqg0nnTCiGu4624w--