From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF98C4363D for ; Thu, 24 Sep 2020 17:10:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BA14238A1 for ; Thu, 24 Sep 2020 17:10:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RoXg1qAp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BA14238A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLUl2-0000Ur-FJ for qemu-devel@archiver.kernel.org; Thu, 24 Sep 2020 13:10:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLUjc-000831-1k for qemu-devel@nongnu.org; Thu, 24 Sep 2020 13:08:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:25452) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLUjZ-0005Dc-L6 for qemu-devel@nongnu.org; Thu, 24 Sep 2020 13:08:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600967320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JUnTPmtpUQh+QHvvBe4EOnh+PCawtjgCn3HGCUw235I=; b=RoXg1qApu2Mund9bY4skm89BcwFbkpoi/ozUISScaT4RbjsvwinOVedpQ2pyP3WStUKhik zrwqjBIxsU01tYpZjkIBcT25pXfJqk4cyLEMAv5ZgyFyG0rO+gdU2uY/tStbZzwhFZieIf o0Z/bMJhbwAG9WXSkOJyczLHIREKTxA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-8TEo771hPJKxcNnJEVaByw-1; Thu, 24 Sep 2020 13:08:36 -0400 X-MC-Unique: 8TEo771hPJKxcNnJEVaByw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E0E77AE835; Thu, 24 Sep 2020 17:08:34 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-114-153.ams2.redhat.com [10.36.114.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A1DA7B7A0; Thu, 24 Sep 2020 17:08:29 +0000 (UTC) Subject: Re: [PATCH v6 09/15] qemu-io: add preallocate mode parameter for truncate command To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20200918181951.21752-1-vsementsov@virtuozzo.com> <20200918181951.21752-10-vsementsov@virtuozzo.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <330c7b66-f53a-360a-c451-02530f222ce6@redhat.com> Date: Thu, 24 Sep 2020 19:08:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200918181951.21752-10-vsementsov@virtuozzo.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SXMaffg9iK4cENfi8wN85XQdQb9RQdzcK" Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/24 01:10:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.214, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SXMaffg9iK4cENfi8wN85XQdQb9RQdzcK Content-Type: multipart/mixed; boundary="tnrdtlBiP6Tu2ViLQt9xZR0mVQtmUXnWm" --tnrdtlBiP6Tu2ViLQt9xZR0mVQtmUXnWm Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 18.09.20 20:19, Vladimir Sementsov-Ogievskiy wrote: > This will be used in further test. >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qemu-io-cmds.c | 46 ++++++++++++++++++++++++++++++++-------------- > 1 file changed, 32 insertions(+), 14 deletions(-) >=20 > diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c > index baeae86d8c..64f0246a71 100644 > --- a/qemu-io-cmds.c > +++ b/qemu-io-cmds.c > @@ -1698,13 +1698,42 @@ static const cmdinfo_t flush_cmd =3D { > .oneline =3D "flush all in-core file state to disk", > }; > =20 > +static int truncate_f(BlockBackend *blk, int argc, char **argv); > +static const cmdinfo_t truncate_cmd =3D { > + .name =3D "truncate", > + .altname =3D "t", > + .cfunc =3D truncate_f, > + .perm =3D BLK_PERM_WRITE | BLK_PERM_RESIZE, > + .argmin =3D 1, > + .argmax =3D 3, > + .args =3D "[-m prealloc_mode] off", > + .oneline =3D "truncates the current file at the given offset", > +}; > + Forward-declaring truncate_cmd instead of truncate_f would mean a smaller diffstat. But that isn=E2=80=99t what other commands do, so. *shrug* Reviewed-by: Max Reitz --tnrdtlBiP6Tu2ViLQt9xZR0mVQtmUXnWm-- --SXMaffg9iK4cENfi8wN85XQdQb9RQdzcK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl9s0owACgkQ9AfbAGHV z0A/mQf+KLYdX0NQumJeDZZm5gBQpRrACIiVxVsFYafr97CHYlzBwzAGda9CxHYO RB/Yls3WNXazM9rwIR1T4SvHc2ie3+BW2JcVIdhWAKlPBCeqd9UCmq1INnS6JUpD 0aPRnGSDd4r0veEoDfJawRRSwTDd+9S5xAkTeGj1qYxWu3yDd//umeXBL4TZnb2C 2F/v3N0WB7J39O3h2De4MD+ga8kgU7XNoWVVWLgO2mS5zzw770hkt2vyVKLa6sEc d6CFRh5H64a+m8rL9t+QdCIjHzVljjv5NKlNRVhlRl886eH4jUvUIL+HTuqlXtux VmO/dP6PKmvtPbEuVAFpdxrDpGA/LQ== =LDC3 -----END PGP SIGNATURE----- --SXMaffg9iK4cENfi8wN85XQdQb9RQdzcK--