Re: [PATCH v3 32/40] tcg/plugins: enable by default for most TCG builds

[Richard Henderson <richard.henderson@linaro.org>]

On 7/9/21 7:29 AM, Alex Bennée wrote:
> Aside from a minor bloat to file size the ability to have TCG plugins
> has no real impact on performance unless a plugin is actively loaded.
> Even then the libempty.so plugin shows only a minor degradation in
> performance caused by the extra book keeping the TCG has to do to keep
> track of instructions. As it's a useful feature lets just enable it by
> default and reduce our testing matrix a little.
> 
> We need to move our linker testing earlier so we can be sure we can
> enable the loader module required. As we have ruled out static &
> plugins in an earlier patch we can also reduce the indent a little.
> 
> Cc: Paolo Bonzini<pbonzini@redhat.com>
> Reviewed-by: Thomas Huth<thuth@redhat.com>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> 
> ---
> v2
>    - properly handle plugins being ""
>    - make the test for linker support handle default case
>    - move linker tests to before the glib-modules test
> v3
>    - remove stray debug ($plugins)
>    - remove no longer needed if static = no check
>    - update commit message
> ---
>   docs/devel/tcg-plugins.rst |   3 +-
>   configure                  | 122 ++++++++++++++++++++-----------------
>   .gitlab-ci.d/buildtest.yml |  23 -------
>   3 files changed, 67 insertions(+), 81 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~