qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: lizhijian@cn.fujitsu.com, xiecl.fnst@cn.fujitsu.com,
	zhangchen.fnst@cn.fujitsu.com, quintela@redhat.com,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 05/18] COLO: Handle shutdown command for VM in COLO state
Date: Mon, 24 Apr 2017 09:51:11 -0500	[thread overview]
Message-ID: <3333f034-0fd2-875f-fbfc-a2c0eda1f09a@redhat.com> (raw)
In-Reply-To: <1492849558-17540-6-git-send-email-zhang.zhanghailiang@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

On 04/22/2017 03:25 AM, zhanghailiang wrote:
> If VM is in COLO FT state, we need to do some extra works before
> starting normal shutdown process.
> 
> Secondary VM will ignore the shutdown command if users issue it directly
> to Secondary VM. COLO will capture shutdown command and after
> shutdown request from user.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---

> +++ b/qapi-schema.json
> @@ -1187,12 +1187,14 @@
>  #
>  # @vmstate-loaded: VM's state has been loaded by SVM.
>  #
> +# @guest-shutdown: shutdown requested from PVM to SVM. (Since 2.9)

You missed 2.9. Please fix this to state 2.10.

> +#
>  # Since: 2.8
>  ##
>  { 'enum': 'COLOMessage',
>    'data': [ 'checkpoint-ready', 'checkpoint-request', 'checkpoint-reply',
>              'vmstate-send', 'vmstate-size', 'vmstate-received',
> -            'vmstate-loaded' ] }
> +            'vmstate-loaded', 'guest-shutdown' ] }
>  


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2017-04-24 14:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-22  8:25 [Qemu-devel] [PATCH v2 00/18] COLO: integrate colo frame with block replication and net compare zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 01/18] net/colo: Add notifier/callback related helpers for filter zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 02/18] colo-compare: implement the process of checkpoint zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 03/18] colo-compare: use notifier to notify packets comparing result zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 04/18] COLO: integrate colo compare with colo frame zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 05/18] COLO: Handle shutdown command for VM in COLO state zhanghailiang
2017-04-24 14:51   ` Eric Blake [this message]
2017-04-26  7:38     ` Hailiang Zhang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 06/18] COLO: Add block replication into colo process zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 07/18] COLO: Load dirty pages into SVM's RAM cache firstly zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 08/18] ram/COLO: Record the dirty pages that SVM received zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 09/18] COLO: Flush memory data from ram cache zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 10/18] qmp event: Add COLO_EXIT event to notify users while exited COLO zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 11/18] savevm: split save/find loadvm_handlers entry into two helper functions zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 12/18] savevm: split the process of different stages for loadvm/savevm zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 13/18] COLO: Separate the process of saving/loading ram and device state zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 14/18] COLO: Split qemu_savevm_state_begin out of checkpoint process zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 15/18] COLO: flush host dirty ram from cache zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 16/18] filter: Add handle_event method for NetFilterClass zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 17/18] filter-rewriter: handle checkpoint and failover event zhanghailiang
2017-04-22  8:25 ` [Qemu-devel] [PATCH v2 18/18] COLO: notify net filters about checkpoint/failover event zhanghailiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3333f034-0fd2-875f-fbfc-a2c0eda1f09a@redhat.com \
    --to=eblake@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=xiecl.fnst@cn.fujitsu.com \
    --cc=zhang.zhanghailiang@huawei.com \
    --cc=zhangchen.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).