Re: [PATCH] tests/vm/haiku.x86_64: Update the Haiku VM to Beta 4

[Thomas Huth <thuth@redhat.com>]

On 16/01/2023 09.30, Thomas Huth wrote:
> The old Haiku VM based on Beta 3 does not work anymore since it
> fails to install the additional packages now that Beta 4 has been
> released. Thanks to Alexander von Gluck IV for providing a new
> image based on Beta 4, we can now upgrade the test image in our
> QEMU CI, too, to get this working again.
> 
> Note that Haiku Beta 4 apparently finally fixed the issue with
> the enumeration of the virtio-block devices (see the ticket at
> https://dev.haiku-os.org/ticket/16512 ) - the tarball disk can
> now be found at index 1 instead of index 0.

I just noticed that we should now remove the related comment, too:

diff a/tests/vm/haiku.x86_64 b/tests/vm/haiku.x86_64
--- a/tests/vm/haiku.x86_64
+++ b/tests/vm/haiku.x86_64
@@ -80,7 +80,6 @@ class HaikuVM(basevm.BaseVM):
          "ninja",
      ]
  
-    # https://dev.haiku-os.org/ticket/16512 virtio disk1 shows up as 0 (reversed order)
      BUILD_SCRIPT = """
          set -e;
          rm -rf /tmp/qemu-test.*