From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHwS5-0002UV-FO for qemu-devel@nongnu.org; Tue, 28 Jun 2016 13:05:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHwS4-0003i7-Eg for qemu-devel@nongnu.org; Tue, 28 Jun 2016 13:05:33 -0400 References: <1466625064-11280-1-git-send-email-jsnow@redhat.com> From: John Snow Message-ID: <335363e0-bbbe-271e-dbb9-841f4cf779f0@redhat.com> Date: Tue, 28 Jun 2016 13:05:22 -0400 MIME-Version: 1.0 In-Reply-To: <1466625064-11280-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] drive-mirror: limit niov to MAX_IOV List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jcody@redhat.com Cc: qemu-block@nongnu.org, kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Ping, all good? Jeff Cody, I think this is yours? On 06/22/2016 03:51 PM, John Snow wrote: > e5b43573 caused a regression in the preparation of our IO vectors, such > that if a small granularity but a large buffer size is chosen, we may > accidentally exceed MAX_IOV and the request will fail. > > This has been fixed before in cae98cb8, and now we'll fix it again. > To keep it fixed, we'll add an iotest this time. > > [Thanks to Max for finding the root cause.] > > John Snow (3): > mirror: clarify mirror_do_read return code > mirror: limit niov to IOV_MAX elements, again > iotests: add small-granularity mirror test > > block/mirror.c | 10 ++++++++-- > tests/qemu-iotests/041 | 30 ++++++++++++++++++++++++++++++ > tests/qemu-iotests/041.out | 4 ++-- > 3 files changed, 40 insertions(+), 4 deletions(-) >