qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.7] atapi: fix halted DMA reset
Date: Thu, 4 Aug 2016 14:29:13 -0400	[thread overview]
Message-ID: <33567f1e-e38b-1160-16b3-79804914e660@redhat.com> (raw)
In-Reply-To: <1470164128-28158-1-git-send-email-jsnow@redhat.com>



On 08/02/2016 02:55 PM, John Snow wrote:
> Followup to 87ac25fd, this time for ATAPI DMA.
>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  hw/ide/atapi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 95056d9..6189675 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -386,6 +386,7 @@ static void ide_atapi_cmd_read_dma_cb(void *opaque, int ret)
>      if (ret < 0) {
>          if (ide_handle_rw_error(s, -ret, ide_dma_cmd_to_retry(s->dma_cmd))) {
>              if (s->bus->error_status) {
> +                s->bus->dma->aiocb = NULL;
>                  return;
>              }
>              goto eot;
>

I extracted an ACK out of Paolo offline, so I have staged this patch.

Thanks, applied to my IDE tree:

https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git

--js

      reply	other threads:[~2016-08-04 18:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 18:55 [Qemu-devel] [PATCH for-2.7] atapi: fix halted DMA reset John Snow
2016-08-04 18:29 ` John Snow [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33567f1e-e38b-1160-16b3-79804914e660@redhat.com \
    --to=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).