* [Qemu-devel] [PATCH for-2.7] atapi: fix halted DMA reset
@ 2016-08-02 18:55 John Snow
2016-08-04 18:29 ` John Snow
0 siblings, 1 reply; 2+ messages in thread
From: John Snow @ 2016-08-02 18:55 UTC (permalink / raw)
To: qemu-block; +Cc: pbonzini, qemu-devel, John Snow
Followup to 87ac25fd, this time for ATAPI DMA.
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
hw/ide/atapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 95056d9..6189675 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@ -386,6 +386,7 @@ static void ide_atapi_cmd_read_dma_cb(void *opaque, int ret)
if (ret < 0) {
if (ide_handle_rw_error(s, -ret, ide_dma_cmd_to_retry(s->dma_cmd))) {
if (s->bus->error_status) {
+ s->bus->dma->aiocb = NULL;
return;
}
goto eot;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.7] atapi: fix halted DMA reset
2016-08-02 18:55 [Qemu-devel] [PATCH for-2.7] atapi: fix halted DMA reset John Snow
@ 2016-08-04 18:29 ` John Snow
0 siblings, 0 replies; 2+ messages in thread
From: John Snow @ 2016-08-04 18:29 UTC (permalink / raw)
To: qemu-block; +Cc: pbonzini, qemu-devel
On 08/02/2016 02:55 PM, John Snow wrote:
> Followup to 87ac25fd, this time for ATAPI DMA.
>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> hw/ide/atapi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 95056d9..6189675 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -386,6 +386,7 @@ static void ide_atapi_cmd_read_dma_cb(void *opaque, int ret)
> if (ret < 0) {
> if (ide_handle_rw_error(s, -ret, ide_dma_cmd_to_retry(s->dma_cmd))) {
> if (s->bus->error_status) {
> + s->bus->dma->aiocb = NULL;
> return;
> }
> goto eot;
>
I extracted an ACK out of Paolo offline, so I have staged this patch.
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-04 18:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-02 18:55 [Qemu-devel] [PATCH for-2.7] atapi: fix halted DMA reset John Snow
2016-08-04 18:29 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).