From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56014)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UnYKu-0006Xt-Bu
	for qemu-devel@nongnu.org; Fri, 14 Jun 2013 14:02:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UnYKq-00065o-LP
	for qemu-devel@nongnu.org; Fri, 14 Jun 2013 14:02:56 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:41911)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UnYKq-00065g-CM
	for qemu-devel@nongnu.org; Fri, 14 Jun 2013 14:02:52 -0400
Date: Fri, 14 Jun 2013 14:02:50 -0400 (EDT)
From: Alon Levy <alevy@redhat.com>
Message-ID: <336668023.19700685.1371232970391.JavaMail.root@redhat.com>
In-Reply-To: <51BAFBFD.5010702@redhat.com>
References: <1371151644-22308-1-git-send-email-alevy@redhat.com>
	<51BAFBFD.5010702@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] make screendump an async command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: airlied@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org

> Hi,
> 
> > Note: due to QAPI not generating async commands yet I had to remove the
> > schema screendump definition.
> 
> Hmm, that will break libvirt I suspect.  Guess this one has to wait
> until QAPI gained proper async command support.

It doesn't break anything. I've tested, and here is the QMP transcript, the only difference is internal to qemu, from libvirt point of view it issues the same command and gets the same response:

$ ./x86_64-softmmu/qemu-system-x86_64 -qmp stdio
{"QMP": {"version": {"qemu": {"micro": 50, "minor": 5, "major": 1}, "package": ""}, "capabilities": []}}
{"execute":"qmp_capabilities"}
{"return": {}}
{"execute":"screendump","arguments":{"filename":"test2.ppm"}}
{"return": {}}


> 
> cheers,
>   Gerd
> 
> 
> 
>