Re: [Qemu-devel] [PATCH 1/5] configure: remove duplicate single quotes on config.log header

[Cleber Rosa <crosa@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]



On 07/27/2017 08:24 AM, Eric Blake wrote:
> On 07/27/2017 07:15 AM, Peter Maydell wrote:
>> On 27 July 2017 at 13:02, Cleber Rosa <crosa@redhat.com> wrote:
>>> The generation of the informational header on config.log contains two
>>> pairs of single quotes, which seems unintentional, and looks like
>>> this:
>>>
>>>   # QEMU configure log Thu Jul 26 08:17:15 EDT 2017
>>>   # Configured with: './configure' '--target-list=x86_64-softmmu'
>>
>> I think this is deliberate. The idea is that the string is a
>> validly shell-quoted string that you can cut and paste
>> into a shell prompt if you want to.
> 
> It IS deliberate.  If you want, you could improve the code to only emit
> '' around arguments that require it rather than all arguments, but that
> requires more shell code (it's easier to quote everywhere, even when it
> looks strange because the quotes weren't necessary).
> 
>> ...and note in particular how the '--cc=ccache gcc' argument
>> is printed.
> 
> Yes, that's a case where the quotes are necessary.
> 

Right, now I can see why.  Thanks for the review!

-- 
Cleber Rosa
[ Sr Software Engineer - Virtualization Team - Red Hat ]
[ Avocado Test Framework - avocado-framework.github.io ]
[  7ABB 96EB 8B46 B94D 5E0F  E9BB 657E 8D33 A5F2 09F3  ]


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]