From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLMMH-0007Px-8t for qemu-devel@nongnu.org; Wed, 23 May 2018 01:30:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLMMG-0004Xn-En for qemu-devel@nongnu.org; Wed, 23 May 2018 01:30:45 -0400 References: <20180522191743.12872-1-pbonzini@redhat.com> From: Thomas Huth Message-ID: <336d4fa2-623c-1cb6-829d-71cf7039431e@redhat.com> Date: Wed, 23 May 2018 07:30:34 +0200 MIME-Version: 1.0 In-Reply-To: <20180522191743.12872-1-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: move at24c to its own CONFIG_ symbol List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org, Michael Davidsaver On 22.05.2018 21:17, Paolo Bonzini wrote: > AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is > being included in all emulators that use I2C, even if they do not > really need it. Separate it and, since it was added for the e500 > machines, add it to qemu-system-ppc and qemu-system-ppc64. > --- > default-configs/ppc-softmmu.mak | 1 + > hw/nvram/Makefile.objs | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak > index 4d7be45ac5..c57e568121 100644 > --- a/default-configs/ppc-softmmu.mak > +++ b/default-configs/ppc-softmmu.mak > @@ -26,6 +26,7 @@ CONFIG_USB_EHCI_SYSBUS=y > CONFIG_SM501=y > CONFIG_IDE_SII3112=y > CONFIG_I2C=y > +CONFIG_AT24C=y > > # For Macs > CONFIG_MAC=y > diff --git a/hw/nvram/Makefile.objs b/hw/nvram/Makefile.objs > index a912d25391..b318e53a43 100644 > --- a/hw/nvram/Makefile.objs > +++ b/hw/nvram/Makefile.objs > @@ -1,6 +1,6 @@ > common-obj-$(CONFIG_DS1225Y) += ds1225y.o > common-obj-y += eeprom93xx.o > -common-obj-$(CONFIG_I2C) += eeprom_at24c.o > +common-obj-$(CONFIG_AT24C) += eeprom_at24c.o > common-obj-y += fw_cfg.o > common-obj-y += chrp_nvram.o > common-obj-$(CONFIG_MAC_NVRAM) += mac_nvram.o Since this is a device that can only be added by the user (no board is using it automatically, as far as I can see), it could be useful for other machines, too, I guess? Anyway, it's a good idea to have a separate config switch available for it, and we can add it to other machines again later if somebody feels that it is necessary, so (once you add your SoB): Reviewed-by: Thomas Huth