* Re: [Qemu-devel] [Qemu-trivial] [PATCH] ppc: move at24c to its own CONFIG_ symbol
2018-05-22 19:17 [Qemu-devel] [PATCH] ppc: move at24c to its own CONFIG_ symbol Paolo Bonzini
@ 2018-05-22 20:31 ` Philippe Mathieu-Daudé
2018-05-23 5:30 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2018-05-24 6:03 ` [Qemu-devel] " Paolo Bonzini
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-22 20:31 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial, qemu-ppc
On 05/22/2018 04:17 PM, Paolo Bonzini wrote:
> AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is
> being included in all emulators that use I2C, even if they do not
> really need it. Separate it and, since it was added for the e500
> machines, add it to qemu-system-ppc and qemu-system-ppc64.
With your S-o-b:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> default-configs/ppc-softmmu.mak | 1 +
> hw/nvram/Makefile.objs | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak
> index 4d7be45ac5..c57e568121 100644
> --- a/default-configs/ppc-softmmu.mak
> +++ b/default-configs/ppc-softmmu.mak
> @@ -26,6 +26,7 @@ CONFIG_USB_EHCI_SYSBUS=y
> CONFIG_SM501=y
> CONFIG_IDE_SII3112=y
> CONFIG_I2C=y
> +CONFIG_AT24C=y
>
> # For Macs
> CONFIG_MAC=y
> diff --git a/hw/nvram/Makefile.objs b/hw/nvram/Makefile.objs
> index a912d25391..b318e53a43 100644
> --- a/hw/nvram/Makefile.objs
> +++ b/hw/nvram/Makefile.objs
> @@ -1,6 +1,6 @@
> common-obj-$(CONFIG_DS1225Y) += ds1225y.o
> common-obj-y += eeprom93xx.o
> -common-obj-$(CONFIG_I2C) += eeprom_at24c.o
> +common-obj-$(CONFIG_AT24C) += eeprom_at24c.o
> common-obj-y += fw_cfg.o
> common-obj-y += chrp_nvram.o
> common-obj-$(CONFIG_MAC_NVRAM) += mac_nvram.o
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: move at24c to its own CONFIG_ symbol
2018-05-22 19:17 [Qemu-devel] [PATCH] ppc: move at24c to its own CONFIG_ symbol Paolo Bonzini
2018-05-22 20:31 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
@ 2018-05-23 5:30 ` Thomas Huth
2018-05-23 14:08 ` Michael Davidsaver
2018-05-24 6:03 ` [Qemu-devel] " Paolo Bonzini
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2018-05-23 5:30 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
Cc: qemu-trivial, qemu-ppc, qemu-arm, Michael Davidsaver
On 22.05.2018 21:17, Paolo Bonzini wrote:
> AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is
> being included in all emulators that use I2C, even if they do not
> really need it. Separate it and, since it was added for the e500
> machines, add it to qemu-system-ppc and qemu-system-ppc64.
> ---
> default-configs/ppc-softmmu.mak | 1 +
> hw/nvram/Makefile.objs | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak
> index 4d7be45ac5..c57e568121 100644
> --- a/default-configs/ppc-softmmu.mak
> +++ b/default-configs/ppc-softmmu.mak
> @@ -26,6 +26,7 @@ CONFIG_USB_EHCI_SYSBUS=y
> CONFIG_SM501=y
> CONFIG_IDE_SII3112=y
> CONFIG_I2C=y
> +CONFIG_AT24C=y
>
> # For Macs
> CONFIG_MAC=y
> diff --git a/hw/nvram/Makefile.objs b/hw/nvram/Makefile.objs
> index a912d25391..b318e53a43 100644
> --- a/hw/nvram/Makefile.objs
> +++ b/hw/nvram/Makefile.objs
> @@ -1,6 +1,6 @@
> common-obj-$(CONFIG_DS1225Y) += ds1225y.o
> common-obj-y += eeprom93xx.o
> -common-obj-$(CONFIG_I2C) += eeprom_at24c.o
> +common-obj-$(CONFIG_AT24C) += eeprom_at24c.o
> common-obj-y += fw_cfg.o
> common-obj-y += chrp_nvram.o
> common-obj-$(CONFIG_MAC_NVRAM) += mac_nvram.o
Since this is a device that can only be added by the user (no board is
using it automatically, as far as I can see), it could be useful for
other machines, too, I guess? Anyway, it's a good idea to have a
separate config switch available for it, and we can add it to other
machines again later if somebody feels that it is necessary, so (once
you add your SoB):
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: move at24c to its own CONFIG_ symbol
2018-05-23 5:30 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
@ 2018-05-23 14:08 ` Michael Davidsaver
0 siblings, 0 replies; 5+ messages in thread
From: Michael Davidsaver @ 2018-05-23 14:08 UTC (permalink / raw)
To: Thomas Huth, Paolo Bonzini, qemu-devel; +Cc: qemu-trivial, qemu-ppc, qemu-arm
On 05/22/2018 10:30 PM, Thomas Huth wrote:
> On 22.05.2018 21:17, Paolo Bonzini wrote:
>> AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is
>> being included in all emulators that use I2C, even if they do not
>> really need it. Separate it and, since it was added for the e500
>> machines, add it to qemu-system-ppc and qemu-system-ppc64.
>> ---
>> default-configs/ppc-softmmu.mak | 1 +
>> hw/nvram/Makefile.objs | 2 +-
>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak
>> index 4d7be45ac5..c57e568121 100644
>> --- a/default-configs/ppc-softmmu.mak
>> +++ b/default-configs/ppc-softmmu.mak
>> @@ -26,6 +26,7 @@ CONFIG_USB_EHCI_SYSBUS=y
>> CONFIG_SM501=y
>> CONFIG_IDE_SII3112=y
>> CONFIG_I2C=y
>> +CONFIG_AT24C=y
>>
>> # For Macs
>> CONFIG_MAC=y
>> diff --git a/hw/nvram/Makefile.objs b/hw/nvram/Makefile.objs
>> index a912d25391..b318e53a43 100644
>> --- a/hw/nvram/Makefile.objs
>> +++ b/hw/nvram/Makefile.objs
>> @@ -1,6 +1,6 @@
>> common-obj-$(CONFIG_DS1225Y) += ds1225y.o
>> common-obj-y += eeprom93xx.o
>> -common-obj-$(CONFIG_I2C) += eeprom_at24c.o
>> +common-obj-$(CONFIG_AT24C) += eeprom_at24c.o
>> common-obj-y += fw_cfg.o
>> common-obj-y += chrp_nvram.o
>> common-obj-$(CONFIG_MAC_NVRAM) += mac_nvram.o
>
> Since this is a device that can only be added by the user (no board is
> using it automatically, as far as I can see),
The board which prompted me to add this device is still out there and
I'm still intent on pursuing getting it into QEMU. It's clearly going
to be some time before this can happen as there are RTC and e500
patches that would need to get in first, and my time to spend on this
has been non-existent in recent months.
https://github.com/mdavidsaver/qemu/commits/vme
> it could be useful for
> other machines, too, I guess? Anyway, it's a good idea to have a
> separate config switch available for it, and we can add it to other
> machines again later if somebody feels that it is necessary, so (once
> you add your SoB):
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] ppc: move at24c to its own CONFIG_ symbol
2018-05-22 19:17 [Qemu-devel] [PATCH] ppc: move at24c to its own CONFIG_ symbol Paolo Bonzini
2018-05-22 20:31 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2018-05-23 5:30 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
@ 2018-05-24 6:03 ` Paolo Bonzini
2 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2018-05-24 6:03 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, qemu-ppc
On 22/05/2018 21:17, Paolo Bonzini wrote:
> AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is
> being included in all emulators that use I2C, even if they do not
> really need it. Separate it and, since it was added for the e500
> machines, add it to qemu-system-ppc and qemu-system-ppc64.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> default-configs/ppc-softmmu.mak | 1 +
> hw/nvram/Makefile.objs | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak
> index 4d7be45ac5..c57e568121 100644
> --- a/default-configs/ppc-softmmu.mak
> +++ b/default-configs/ppc-softmmu.mak
> @@ -26,6 +26,7 @@ CONFIG_USB_EHCI_SYSBUS=y
> CONFIG_SM501=y
> CONFIG_IDE_SII3112=y
> CONFIG_I2C=y
> +CONFIG_AT24C=y
>
> # For Macs
> CONFIG_MAC=y
> diff --git a/hw/nvram/Makefile.objs b/hw/nvram/Makefile.objs
> index a912d25391..b318e53a43 100644
> --- a/hw/nvram/Makefile.objs
> +++ b/hw/nvram/Makefile.objs
> @@ -1,6 +1,6 @@
> common-obj-$(CONFIG_DS1225Y) += ds1225y.o
> common-obj-y += eeprom93xx.o
> -common-obj-$(CONFIG_I2C) += eeprom_at24c.o
> +common-obj-$(CONFIG_AT24C) += eeprom_at24c.o
> common-obj-y += fw_cfg.o
> common-obj-y += chrp_nvram.o
> common-obj-$(CONFIG_MAC_NVRAM) += mac_nvram.o
>
^ permalink raw reply [flat|nested] 5+ messages in thread