qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Yonggang Luo" <luoyonggang@gmail.com>,
	"Akihiko Odaki" <akihiko.odaki@daynix.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Subject: Re: [PATCH v2 2/3] tests/functional: Introduce the dso_suffix() helper
Date: Thu, 20 Feb 2025 09:03:59 +0100	[thread overview]
Message-ID: <3390aa1d-2505-414d-afc7-92df46d445c4@linaro.org> (raw)
In-Reply-To: <20250220080215.49165-3-philmd@linaro.org>

On 20/2/25 09:02, Philippe Mathieu-Daudé wrote:
> Introduce a helper to get the default shared library
> suffix used on the host.
> 
> Suggested-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   tests/functional/qemu_test/__init__.py | 2 +-
>   tests/functional/qemu_test/cmd.py      | 1 -
>   tests/functional/qemu_test/config.py   | 6 ++++++
>   3 files changed, 7 insertions(+), 2 deletions(-)


> diff --git a/tests/functional/qemu_test/cmd.py b/tests/functional/qemu_test/cmd.py
> index dc5f422b77d..254e23ef748 100644
> --- a/tests/functional/qemu_test/cmd.py
> +++ b/tests/functional/qemu_test/cmd.py
> @@ -15,7 +15,6 @@
>   import os
>   import os.path
>   
> -

Oops, Alex, should I respin a v3 removing this change?

>   def which(tool):
>       """ looks up the full path for @tool, returns None if not found
>           or if @tool does not have executable permissions.


  reply	other threads:[~2025-02-20  8:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20  8:02 [PATCH v2 0/3] tests/functional: Allow running TCG plugins tests on macOS Philippe Mathieu-Daudé
2025-02-20  8:02 ` [PATCH v2 1/3] plugins: add explicit dependency in functional tests Philippe Mathieu-Daudé
2025-02-20  8:02 ` [PATCH v2 2/3] tests/functional: Introduce the dso_suffix() helper Philippe Mathieu-Daudé
2025-02-20  8:03   ` Philippe Mathieu-Daudé [this message]
2025-02-20  8:05   ` Thomas Huth
2025-02-27  7:06   ` Akihiko Odaki
2025-02-27  7:55     ` Alex Bennée
2025-02-27  9:00   ` Daniel P. Berrangé
2025-02-20  8:02 ` [PATCH v2 3/3] tests/functional: Allow running TCG plugins tests on non-Linux/BSD hosts Philippe Mathieu-Daudé
2025-02-20  8:28   ` Thomas Huth
2025-02-20  9:18 ` [PATCH v2 0/3] tests/functional: Allow running TCG plugins tests on macOS Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3390aa1d-2505-414d-afc7-92df46d445c4@linaro.org \
    --to=philmd@linaro.org \
    --cc=akihiko.odaki@daynix.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=erdnaxe@crans.org \
    --cc=luoyonggang@gmail.com \
    --cc=ma.mandourr@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).