From: Paolo Bonzini <pbonzini@redhat.com>
To: Kit Westneat <kit.westneat@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 2/3] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test
Date: Wed, 26 May 2021 16:40:12 +0200 [thread overview]
Message-ID: <3394c913-3478-734b-2c6b-8f213d889ab4@redhat.com> (raw)
In-Reply-To: <20210525194607.553291-3-kit.westneat@gmail.com>
On 25/05/21 21:46, Kit Westneat wrote:
> +static void *virtio_scsi_setup_4k(GString *cmd_line, void *arg)
> +{
> + g_string_append(cmd_line,
> + " -drive file=blkdebug::null-co://,"
> + "file.image.read-zeroes=on,"
> + "if=none,id=dr1,format=raw,file.blocksize=4k "
> + "-device scsi-hd,drive=dr1,lun=0,scsi-id=1");
Instead of having patches 1+3, I think it's enough to use "-device
scsi-hd,...,logical_block_size=4096".
Thanks,
Paolo
next prev parent reply other threads:[~2021-05-26 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 19:46 [PATCH v3 0/3] testing block device blocksizes Kit Westneat
2021-05-25 19:46 ` [PATCH v3 1/3] block/blkdebug: add blocksize parameter Kit Westneat
2021-05-25 19:46 ` [PATCH v3 2/3] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test Kit Westneat
2021-05-26 14:40 ` Paolo Bonzini [this message]
2021-05-25 19:46 ` [PATCH v3 3/3] block/blkdebug: add log-blocksize and phys-blocksize parameters Kit Westneat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3394c913-3478-734b-2c6b-8f213d889ab4@redhat.com \
--to=pbonzini@redhat.com \
--cc=kit.westneat@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).