qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: Stefan Berger <stefanb@linux.ibm.com>,
	marcandre.lureau@gmail.com, ppandit@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] tpm: Remove unused locty parameter from tpm_tis_abort()
Date: Tue, 20 Nov 2018 21:10:45 +0100	[thread overview]
Message-ID: <33969753-1937-307c-44e3-db27129f0035@redhat.com> (raw)
In-Reply-To: <20181120182721.227114-2-stefanb@linux.vnet.ibm.com>

On 20/11/18 19:27, Stefan Berger wrote:
> Remove the unused locty parameter from tpm_tis_abort() function.
> 
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   hw/tpm/tpm_tis.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
> index d9322692ee..176d424ed9 100644
> --- a/hw/tpm/tpm_tis.c
> +++ b/hw/tpm/tpm_tis.c
> @@ -233,7 +233,7 @@ static void tpm_tis_new_active_locality(TPMState *s, uint8_t new_active_locty)
>   }
>   
>   /* abort -- this function switches the locality */
> -static void tpm_tis_abort(TPMState *s, uint8_t locty)
> +static void tpm_tis_abort(TPMState *s)
>   {
>       s->rw_offset = 0;
>   
> @@ -281,7 +281,7 @@ static void tpm_tis_prep_abort(TPMState *s, uint8_t locty, uint8_t newlocty)
>           }
>       }
>   
> -    tpm_tis_abort(s, locty);
> +    tpm_tis_abort(s);
>   }
>   
>   /*
> @@ -311,7 +311,7 @@ static void tpm_tis_request_completed(TPMIf *ti, int ret)
>       }
>   
>       if (TPM_TIS_IS_VALID_LOCTY(s->next_locty)) {
> -        tpm_tis_abort(s, locty);
> +        tpm_tis_abort(s);
>       }
>   
>       tpm_tis_raise_irq(s, locty,
> 

  reply	other threads:[~2018-11-20 20:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 18:27 [Qemu-devel] [PATCH 0/2] tpm: Cleanup and locality range check Stefan Berger
2018-11-20 18:27 ` [Qemu-devel] [PATCH 1/2] tpm: Remove unused locty parameter from tpm_tis_abort() Stefan Berger
2018-11-20 20:10   ` Philippe Mathieu-Daudé [this message]
2018-11-20 18:27 ` [Qemu-devel] [PATCH 2/2] tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid Stefan Berger
2018-11-22  0:27 ` [Qemu-devel] [PATCH 0/2] tpm: Cleanup and locality range check no-reply
2018-11-22  0:29 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33969753-1937-307c-44e3-db27129f0035@redhat.com \
    --to=philmd@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.ibm.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).