From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX8s5-0001I8-Cx for qemu-devel@nongnu.org; Tue, 09 Aug 2016 11:23:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX8s1-0003ET-5o for qemu-devel@nongnu.org; Tue, 09 Aug 2016 11:23:12 -0400 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:63129 helo=SMTP.EU.CITRIX.COM) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX8s0-0003Dz-Vq for qemu-devel@nongnu.org; Tue, 09 Aug 2016 11:23:09 -0400 From: Paul Durrant Date: Tue, 9 Aug 2016 15:23:05 +0000 Message-ID: <339fd6631cba40518264719ba8cf2018@AMSPEX02CL03.citrite.net> References: <1470042985-680-1-git-send-email-paul.durrant@citrix.com> <20160809151912.GC1835@perard.uk.xensource.com> In-Reply-To: <20160809151912.GC1835@perard.uk.xensource.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] xen: handle inbound migration of VMs without ioreq server pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Perard Cc: "xen-devel@lists.xenproject.org" , "qemu-devel@nongnu.org" , Stefano Stabellini > -----Original Message----- > From: Anthony PERARD [mailto:anthony.perard@citrix.com] > Sent: 09 August 2016 16:19 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; qemu-devel@nongnu.org; Stefano > Stabellini > Subject: Re: [PATCH] xen: handle inbound migration of VMs without ioreq > server pages >=20 > On Mon, Aug 01, 2016 at 10:16:25AM +0100, Paul Durrant wrote: > > VMs created on older versions on Xen will not have been provisioned wit= h > > pages to support creation of non-default ioreq servers. In this case > > the ioreq server API is not supported and QEMU's only option is to fall > > back to using the default ioreq server pages as it did prior to > > commit 3996e85c ("Xen: Use the ioreq-server API when available"). > > > > This patch therefore changes the code in xen_common.h to stop > considering > > a failure of xc_hvm_create_ioreq_server() as a hard failure but simply > > as an indication that the guest is too old to support the ioreq server > > API. Instead a boolean is set to cause reversion to old behaviour such > > that the default ioreq server is then used. > > > > Signed-off-by: Paul Durrant > > Cc: Stefano Stabellini > > Cc: Anthony Perard >=20 > There are just two lines too long: >=20 > WARNING: line over 80 characters > #31: FILE: include/hw/xen/xen_common.h:110: > +static inline int xen_get_default_ioreq_server_info(xc_interface *xc, > domid_t dom, >=20 > WARNING: line over 80 characters > #34: FILE: include/hw/xen/xen_common.h:113: > + evtchn_port_t *bufio= req_evtchn) >=20 > With that fixed: Acked-by: Anthony PERARD >=20 > Thanks, >=20 Ok, I'll post v2 with those fixes and your ack. Thanks, Paul > -- > Anthony PERARD