From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Fam Zheng <famz@redhat.com>,
qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
Jeff Cody <jcody@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 12/17] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes
Date: Wed, 12 Jul 2017 15:25:12 -0400 [thread overview]
Message-ID: <33a6149c-184d-74c6-3bb6-36cb28adc5bf@redhat.com> (raw)
In-Reply-To: <20170703151051.31327-13-eblake@redhat.com>
On 07/03/2017 11:10 AM, Eric Blake wrote:
> Some of the callers were already scaling bytes to sectors; others
> can be easily converted to pass byte offsets, all in our shift
> towards a consistent byte interface everywhere. Making the change
> will also make it easier to write the hold-out callers to use byte
> rather than sectors for their iterations; it also makes it easier
> for a future dirty-bitmap patch to offload scaling over to the
> internal hbitmap. Although all callers happen to pass
> sector-aligned values, make the internal scaling robust to any
> sub-sector requests.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2017-07-12 19:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 15:10 [Qemu-devel] [PATCH v4 00/17] make dirty-bitmap byte-based Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 01/17] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 02/17] hbitmap: Rename serialization_granularity to serialization_align Eric Blake
2017-07-06 23:03 ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 03/17] qcow2: Ensure bitmap serialization is aligned Eric Blake
2017-07-06 23:14 ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 04/17] dirty-bitmap: Drop unused functions Eric Blake
2017-07-06 23:43 ` John Snow
2017-07-07 8:44 ` Vladimir Sementsov-Ogievskiy
2017-07-07 13:05 ` Vladimir Sementsov-Ogievskiy
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 05/17] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes Eric Blake
2017-07-10 21:09 ` John Snow
2017-07-10 21:19 ` Eric Blake
2017-07-10 21:20 ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 06/17] dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes Eric Blake
2017-07-10 21:46 ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 07/17] qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based Eric Blake
2017-07-10 22:54 ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 08/17] dirty-bitmap: Set iterator start by offset, not sector Eric Blake
2017-07-10 23:02 ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 09/17] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset Eric Blake
2017-07-10 23:20 ` John Snow
2017-07-11 16:50 ` Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 10/17] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 11/17] dirty-bitmap: Change bdrv_get_dirty_locked() to take bytes Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 12/17] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes Eric Blake
2017-07-12 19:25 ` John Snow [this message]
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 13/17] mirror: Switch mirror_dirty_init() to byte-based iteration Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 14/17] qcow2: Switch load_bitmap_data() " Eric Blake
2017-07-12 20:15 ` John Snow
2017-07-13 9:16 ` Vladimir Sementsov-Ogievskiy
2017-07-13 10:59 ` Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 15/17] qcow2: Switch store_bitmap_data() " Eric Blake
2017-07-12 20:28 ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 16/17] dirty-bitmap: Switch bdrv_set_dirty() to bytes Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 17/17] dirty-bitmap: Convert internal hbitmap size/granularity Eric Blake
2017-07-12 21:00 ` John Snow
2017-07-12 21:25 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a6149c-184d-74c6-3bb6-36cb28adc5bf@redhat.com \
--to=jsnow@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).