* [Qemu-devel] [PATCH] qmp-test: fix response leak
@ 2018-03-26 17:20 Marc-André Lureau
2018-03-26 18:33 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Marc-André Lureau @ 2018-03-26 17:20 UTC (permalink / raw)
To: qemu-devel; +Cc: peterx, eblake, Marc-André Lureau
Apparently introduced in commit a4f90923b520f1dc0a768634877eb412e5052c26.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/qmp-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index 558e83540c..8de99a4727 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -90,6 +90,7 @@ static void test_qmp_protocol(void)
test_version(qdict_get(q, "version"));
capabilities = qdict_get_qlist(q, "capabilities");
g_assert(capabilities && qlist_empty(capabilities));
+ QDECREF(resp);
/* Test valid command before handshake */
resp = qtest_qmp(qts, "{ 'execute': 'query-version' }");
--
2.17.0.rc1.1.g4c4f2b46a3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qmp-test: fix response leak
2018-03-26 17:20 [Qemu-devel] [PATCH] qmp-test: fix response leak Marc-André Lureau
@ 2018-03-26 18:33 ` Eric Blake
2018-03-26 21:57 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2018-03-26 18:33 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel; +Cc: peterx
On 03/26/2018 12:20 PM, Marc-André Lureau wrote:
> Apparently introduced in commit a4f90923b520f1dc0a768634877eb412e5052c26.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/qmp-test.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
I'll queue this through my qapi tree, unless applying Peter's for-2.12
patches fixes it differently.
>
> diff --git a/tests/qmp-test.c b/tests/qmp-test.c
> index 558e83540c..8de99a4727 100644
> --- a/tests/qmp-test.c
> +++ b/tests/qmp-test.c
> @@ -90,6 +90,7 @@ static void test_qmp_protocol(void)
> test_version(qdict_get(q, "version"));
> capabilities = qdict_get_qlist(q, "capabilities");
> g_assert(capabilities && qlist_empty(capabilities));
> + QDECREF(resp);
>
> /* Test valid command before handshake */
> resp = qtest_qmp(qts, "{ 'execute': 'query-version' }");
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qmp-test: fix response leak
2018-03-26 18:33 ` Eric Blake
@ 2018-03-26 21:57 ` Eric Blake
0 siblings, 0 replies; 3+ messages in thread
From: Eric Blake @ 2018-03-26 21:57 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel; +Cc: peterx
On 03/26/2018 01:33 PM, Eric Blake wrote:
> On 03/26/2018 12:20 PM, Marc-André Lureau wrote:
>> Apparently introduced in commit a4f90923b520f1dc0a768634877eb412e5052c26.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>> tests/qmp-test.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> I'll queue this through my qapi tree, unless applying Peter's for-2.12
> patches fixes it differently.
Okay, it's needed, and I'm queuing it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-26 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-26 17:20 [Qemu-devel] [PATCH] qmp-test: fix response leak Marc-André Lureau
2018-03-26 18:33 ` Eric Blake
2018-03-26 21:57 ` Eric Blake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).