From: Eric Blake <eblake@redhat.com>
To: "Simran Singhal" <singhalsimran0@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
"Peter Lieven" <pl@kamp.de>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Julia Suvorova" <jusual@mail.ru>
Subject: Re: [PATCH] Compress lines for immediate return
Date: Wed, 1 Apr 2020 10:45:01 -0500 [thread overview]
Message-ID: <33d40ebc-00d1-28d2-f278-2419ab636b45@redhat.com> (raw)
In-Reply-To: <CALrZqyNpvKeH6E2KCLQoCt1H1qphktWuX8i-cwoMOH6_g0Qu4g@mail.gmail.com>
On 4/1/20 9:49 AM, Simran Singhal wrote:
> Hello Philippe
>
> On Wed, Apr 1, 2020 at 7:26 PM Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>
>> Hi Simran,
>>
>> On 4/1/20 2:11 PM, Simran Singhal wrote:
>>> Compress two lines into a single line if immediate return statement is
>> found.
>>
>> How did you find these changes? Manual audit, some tool?
>>
>
> I wrote coccinelle script to do these changes.
>
Then is it worth checking in your script to scripts/coccinelle/ to let
it be something we can repeatedly rerun in the future to catch more
instances? Even if you don't go that far, mentioning the exact rune you
used makes it easier to reproduce the patch, or even backport its
effects to a different branch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-04-01 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 12:11 [PATCH] Compress lines for immediate return Simran Singhal
2020-04-01 13:27 ` Dr. David Alan Gilbert
2020-04-01 13:56 ` Philippe Mathieu-Daudé
2020-04-01 14:49 ` Simran Singhal
2020-04-01 15:45 ` Eric Blake [this message]
2020-04-01 16:36 ` Simran Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33d40ebc-00d1-28d2-f278-2419ab636b45@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=jusual@mail.ru \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).