From: Eric Blake <eblake@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, armbru@redhat.com, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 4/5] block/rbd: add blockdev-add support
Date: Mon, 27 Feb 2017 16:40:34 -0600 [thread overview]
Message-ID: <33e252c2-4025-db70-5a59-7cdc6445a97f@redhat.com> (raw)
In-Reply-To: <3d09a265f288145ddd8a0159c72ce343d32c30ff.1488220970.git.jcody@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2899 bytes --]
On 02/27/2017 12:58 PM, Jeff Cody wrote:
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> qapi/block-core.json | 34 +++++++++++++++++++++++++++++++---
> 1 file changed, 31 insertions(+), 3 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 5f82d35..5b311ff 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2111,6 +2111,7 @@
> # @replication: Since 2.8
> # @ssh: Since 2.8
> # @iscsi: Since 2.9
> +# @rbd: Since 2.9
> #
> # Since: 2.0
> ##
> @@ -2120,7 +2121,7 @@
> 'host_device', 'http', 'https', 'iscsi', 'luks', 'nbd', 'nfs',
> 'null-aio', 'null-co', 'parallels', 'qcow', 'qcow2', 'qed',
> 'quorum', 'raw', 'replication', 'ssh', 'vdi', 'vhdx', 'vmdk',
> - 'vpc', 'vvfat' ] }
> + 'vpc', 'vvfat', 'rbd' ] }
Please keep the list alphabetical.
>
> ##
> # @BlockdevOptionsFile:
> @@ -2376,7 +2377,6 @@
> 'path': 'str',
> '*user': 'str' } }
>
> -
> ##
> # @BlkdebugEvent:
> #
Spurious hunk?
> @@ -2666,6 +2666,34 @@
> '*timeout': 'int' } }
>
> ##
> +# @BlockdevOptionsRbd:
> +#
> +# @pool: Ceph pool name.
> +#
> +# @image: Image name in the Ceph pool.
> +#
> +# @conf: # optional path to Ceph configuration file. Values
No space between # and optional
> +# in the configuration file will be overridden by
> +# options specified via QAPI.
> +#
> +# @snapshot: #optional Ceph snapshot name.
> +#
> +# @user: #optional Ceph id name.
> +#
> +# @password-secret: #optional The ID of a QCryptoSecret object providing
> +# the password for the login.
Indentation off?
> +#
> +# Since: 2.9
> +##
> +{ 'struct': 'BlockdevOptionsRbd',
> + 'data': { 'pool': 'str',
> + 'image': 'str',
> + '*conf': 'str',
> + '*snapshot': 'str',
> + '*user': 'str',
> + '*password-secret': 'str' } }
> +
> +##
> # @ReplicationMode:
> #
> # An enumeration of replication modes.
> @@ -2863,7 +2891,7 @@
> 'qed': 'BlockdevOptionsGenericCOWFormat',
> 'quorum': 'BlockdevOptionsQuorum',
> 'raw': 'BlockdevOptionsRaw',
> -# TODO rbd: Wait for structured options
> + 'rbd': 'BlockdevOptionsRbd',
> 'replication':'BlockdevOptionsReplication',
> # TODO sheepdog: Wait for structured options
> 'ssh': 'BlockdevOptionsSsh',
>
Omits the problematic keyvalue-pairs, and otherwise matches the previous
patches. With the nits fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-02-27 22:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 18:58 [Qemu-devel] [PATCH v2 0/5] RBD: blockdev-add Jeff Cody
2017-02-27 18:58 ` [Qemu-devel] [PATCH v2 1/5] block/rbd: don't copy strings in qemu_rbd_next_tok() Jeff Cody
2017-02-27 19:46 ` Markus Armbruster
2017-02-27 21:26 ` Eric Blake
2017-02-27 18:58 ` [Qemu-devel] [PATCH v2 2/5] block/rbd: add all the currently supported runtime_opts Jeff Cody
2017-02-27 22:18 ` Eric Blake
2017-02-27 22:24 ` Jeff Cody
2017-02-27 18:58 ` [Qemu-devel] [PATCH v2 3/5] block/rbd: parse all options via bdrv_parse_filename Jeff Cody
2017-02-27 22:35 ` Eric Blake
2017-02-27 22:56 ` Jeff Cody
2017-02-27 23:15 ` Eric Blake
2017-02-27 18:58 ` [Qemu-devel] [PATCH v2 4/5] block/rbd: add blockdev-add support Jeff Cody
2017-02-27 22:40 ` Eric Blake [this message]
2017-02-27 18:58 ` [Qemu-devel] [PATCH v2 5/5] block/rbd: add support for 'mon_host', 'auth_supported' via QAPI Jeff Cody
2017-02-27 19:54 ` Daniel P. Berrange
2017-02-27 22:47 ` Eric Blake
2017-02-27 23:02 ` Jeff Cody
2017-02-28 3:57 ` Jeff Cody
2017-02-28 10:16 ` Daniel P. Berrange
2017-02-28 10:28 ` Daniel P. Berrange
2017-02-28 12:34 ` Jeff Cody
2017-02-28 12:49 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33e252c2-4025-db70-5a59-7cdc6445a97f@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).