From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v3 05/17] plugins: scoreboard API
Date: Mon, 12 Feb 2024 10:24:12 +0400 [thread overview]
Message-ID: <3402d8b4-9092-465d-8660-9eeabb0a59d6@linaro.org> (raw)
In-Reply-To: <acafbcf1-8606-4450-8720-d96078fe5b03@linaro.org>
On 2/11/24 23:13, Richard Henderson wrote:
> On 2/11/24 04:26, Pierrick Bouvier wrote:
>> On 2/11/24 04:41, Richard Henderson wrote:
>>> On 2/6/24 19:59, Pierrick Bouvier wrote:
>>>>> Why a hash table? All you want is to be able to iterate through all, and add/remove
>>>>> easily. Seems like QLIST from <qemu/queue.h> would be better, and the QLIST_ENTRY member
>>>>> would make struct qemu_plugin_scoreboard useful.
>>>>>
>>>>
>>>> Thought that having O(1) removal was a nice property, compared to a linked list. I can
>>>> switch to a QLIST if you still think it's better.
>>>
>>> QLIST is double-linked, so it's still O(1).
>>>
>>>
>>
>> Is it an "intrusive" linked list (where next and prev are part of the struct entry itself)?
>
> Yes.
>
Sounds good then, I'll switch to QLIST.
>
> r~
next prev parent reply other threads:[~2024-02-12 6:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 9:24 [PATCH v3 00/17] TCG Plugin inline operation enhancement Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 01/17] plugins: remove previous n_vcpus functions from API Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 02/17] plugins: add qemu_plugin_num_vcpus function Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 03/17] plugins: fix order of init/idle/resume callback Pierrick Bouvier
2024-02-07 2:59 ` Richard Henderson
2024-02-06 9:24 ` [PATCH v3 04/17] cpu: call plugin init hook asynchronously Pierrick Bouvier
2024-02-07 3:00 ` Richard Henderson
2024-02-06 9:24 ` [PATCH v3 05/17] plugins: scoreboard API Pierrick Bouvier
2024-02-07 3:21 ` Richard Henderson
2024-02-07 5:59 ` Pierrick Bouvier
2024-02-11 0:41 ` Richard Henderson
2024-02-11 14:26 ` Pierrick Bouvier
2024-02-11 19:13 ` Richard Henderson
2024-02-12 6:24 ` Pierrick Bouvier [this message]
2024-02-06 9:24 ` [PATCH v3 06/17] docs/devel: plugins can trigger a tb flush Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 07/17] plugins: implement inline operation relative to cpu_index Pierrick Bouvier
2024-02-07 3:42 ` Richard Henderson
2024-02-07 6:01 ` Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 08/17] plugins: add inline operation per vcpu Pierrick Bouvier
2024-02-07 3:45 ` Richard Henderson
2024-02-07 6:05 ` Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 09/17] tests/plugin: add test plugin for inline operations Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 10/17] tests/plugin/mem: migrate to new per_vcpu API Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 11/17] tests/plugin/insn: " Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 12/17] tests/plugin/bb: " Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 13/17] contrib/plugins/hotblocks: " Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 14/17] contrib/plugins/howvec: " Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 15/17] plugins: remove non per_vcpu inline operation from API Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 16/17] plugins: cleanup codepath for previous inline operation Pierrick Bouvier
2024-02-06 9:24 ` [PATCH v3 17/17] MAINTAINERS: Add myself as reviewer for TCG Plugins Pierrick Bouvier
2024-02-07 15:45 ` [PATCH v3 00/17] TCG Plugin inline operation enhancement Alex Bennée
2024-02-07 16:06 ` Alex Bennée
2024-02-07 18:21 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3402d8b4-9092-465d-8660-9eeabb0a59d6@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).