From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YalmM-0008Do-44 for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:55:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YalmI-0000ec-2u for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:55:29 -0400 Received: from cmexedge1.emulex.com ([138.239.224.99]:24415 helo=CMEXEDGE1.ext.emulex.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YalmH-0000dz-To for qemu-devel@nongnu.org; Wed, 25 Mar 2015 09:55:26 -0400 From: Padmanabh Ratnakar Date: Wed, 25 Mar 2015 13:54:53 +0000 Message-ID: <34033ecd-ff30-484c-9dba-253b230e30b4@CMEXHTCAS2.ad.emulex.com> References: <4bc35b66-3d20-411a-a6d1-6f3263a13758@CMEXHTCAS2.ad.emulex.com> <87r3sd1fyu.fsf@neno.neno> In-Reply-To: <87r3sd1fyu.fsf@neno.neno> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] rdma: Fix cleanup in error paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "quintela@redhat.com" Cc: "amit.shah@redhat.com" , Meghana Cheripady , "qemu-devel@nongnu.org" , "mrhines@us.ibm.com" >=20 > This other three are nice, remove code, and make it correct with the case > that qp has to be removed first. >=20 > So, should we drop the listen_id part, or there is a reason for it? >=20 > Later, Juan. >=20 listen_id is used only in server side. Saw that listen_id gets created before cm_id. So for symmetry destroyed cm_id before listen_id. Checked the status of rdma_destroy_id() and both connection identifier were= getting destroyed successfully. Please see if I am missing something and should I revert this change. =20 Thanks, Padmanabh