From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, berto@igalia.com,
wencongyang2@huawei.com, xiechanglong.d@gmail.com,
stefanha@redhat.com, den@openvz.org,
andrey.shinkevich@virtuozzo.com, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 2/3] block/stream: refactor stream_run: drop goto
Date: Tue, 28 May 2019 19:17:29 +0200 [thread overview]
Message-ID: <3418f89f-25ef-3a8a-53d2-466278c6ed82@redhat.com> (raw)
In-Reply-To: <20190506153429.52737-3-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On 06.05.19 17:34, Vladimir Sementsov-Ogievskiy wrote:
> The goto is unnecessary in the stream_run() since the common exit
> code was removed in the commit eb23654dbe43b549ea2a9ebff9d8e:
> "jobs: utilize job_exit shim".
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
> ---
> block/stream.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-28 17:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 15:34 [Qemu-devel] [PATCH v6 0/3] block/stream: get rid of the base Vladimir Sementsov-Ogievskiy
2019-05-06 15:34 ` [Qemu-devel] [PATCH v6 1/3] block: include base when checking image chain for block allocation Vladimir Sementsov-Ogievskiy
2019-05-28 17:15 ` Max Reitz
2019-05-06 15:34 ` [Qemu-devel] [PATCH v6 2/3] block/stream: refactor stream_run: drop goto Vladimir Sementsov-Ogievskiy
2019-05-28 17:17 ` Max Reitz [this message]
2019-05-06 15:34 ` [Qemu-devel] [PATCH v6 3/3] block/stream: introduce a bottom node Vladimir Sementsov-Ogievskiy
2019-05-28 17:33 ` Max Reitz
2019-05-29 7:34 ` Vladimir Sementsov-Ogievskiy
2019-05-29 11:23 ` Max Reitz
2019-05-29 11:44 ` Vladimir Sementsov-Ogievskiy
2019-05-29 11:53 ` Max Reitz
2019-05-21 7:51 ` [Qemu-devel] [PATCH v6 0/3] block/stream: get rid of the base Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3418f89f-25ef-3a8a-53d2-466278c6ed82@redhat.com \
--to=mreitz@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).