From: Richard Henderson <richard.henderson@linaro.org>
To: Lucas Dietrich <ld.adecy@gmail.com>, philmd@linaro.org
Cc: qemu-devel@nongnu.org, mrolnik@gmail.com, qemu-trivial@nongnu.org
Subject: Re: [PATCH] Fix handling of AVR interrupts above 33.
Date: Wed, 14 Jun 2023 06:32:41 +0200	[thread overview]
Message-ID: <341999c5-2cac-7f25-441c-0e5bd9db4ee4@linaro.org> (raw)
In-Reply-To: <20230613193446.4372-1-ld.adecy@gmail.com>
On 6/13/23 21:34, Lucas Dietrich wrote:
> This commit addresses a bug in the AVR interrupt handling code.
> The modification involves replacing the usage of the ctz32 function
> with ctz64 to ensure proper handling of interrupts above 33 in the AVR
> target.
> 
> Previously, timers 3, 4, and 5 interrupts were not functioning correctly
> because most of their interrupt vectors are numbered above 33.
> 
> Signed-off-by: Lucas Dietrich <ld.adecy@gmail.com>
The change to target/avr/ looks right, but you shouldn't have all the subproject changes.
r~
> ---
>   capstone                      | 1 +
>   dtc                           | 1 +
>   meson                         | 1 +
>   roms/sgabios                  | 1 +
>   slirp                         | 1 +
>   target/avr/helper.c           | 4 ++--
>   tests/fp/berkeley-softfloat-3 | 1 +
>   tests/fp/berkeley-testfloat-3 | 1 +
>   ui/keycodemapdb               | 1 +
>   9 files changed, 10 insertions(+), 2 deletions(-)
>   create mode 160000 capstone
>   create mode 160000 dtc
>   create mode 160000 meson
>   create mode 160000 roms/sgabios
>   create mode 160000 slirp
>   create mode 160000 tests/fp/berkeley-softfloat-3
>   create mode 160000 tests/fp/berkeley-testfloat-3
>   create mode 160000 ui/keycodemapdb
next prev parent reply	other threads:[~2023-06-14  4:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-13 19:34 [PATCH] Fix handling of AVR interrupts above 33 Lucas Dietrich
2023-06-14  4:32 ` Richard Henderson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-14 14:07 Lucas Dietrich
2023-06-14 12:22 ` Philippe Mathieu-Daudé
2023-06-14 12:29   ` Michael Rolnik
2023-06-18  6:56 ` Michael Tokarev
2023-06-18 10:27   ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=341999c5-2cac-7f25-441c-0e5bd9db4ee4@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=ld.adecy@gmail.com \
    --cc=mrolnik@gmail.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).