qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org
Cc: "Dorinda Bassey" <dbassey@redhat.com>,
	qemu-devel@nongnu.org, kraxel@redhat.com, armbru@redhat.com,
	pbonzini@redhat.com, wtaymans@redhat.com,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU
Date: Thu, 16 Feb 2023 12:53:41 +0100	[thread overview]
Message-ID: <3423015.TuE8vhHZVa@silver> (raw)
In-Reply-To: <Y+0BcwxQ2INww8dN@redhat.com>

On Wednesday, February 15, 2023 4:59:47 PM CET Daniel P. Berrangé wrote:
> On Wed, Feb 15, 2023 at 05:18:50PM +0400, Marc-André Lureau wrote:
> > Hi
> > 
> > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey <dbassey@redhat.com> wrote:
> > >
> > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems.
> > >
> > 
> > Hmm, I would rather have less audio (and ui) backends in QEMU. (for
> > audio, if I could introduce and keep only one, that would be
> > GStreamer: to remove the others..)
> 
> Even if we take this patch, and don't have a gstreamer impl,
> it feels like we've scope for cutting down the backends.
> 
> The 'oss' driver for example ?  On Linux that's long obsolete,
> with alsa or one of the higher level APIs available.  OSS was
> also use on freebsd, but IIUC,  sndio is better choice there
> now too ?  Deprecate (and later remove) 'oss' now ?

There is indeed little reason to still use OSS nowadays IMO. At least marking
OSS as deprecated would not hurt.

> The 'sdl' driver is setup in meson.build as our lowest priority
> impl, we'll pick any other driver ahead of sdl. Is there any
> compelling reason why we must give users the option of 'sdl'
> for audio when we have soo many other choices available ?
> Even if using SDL for graphics, it seems like we can use any
> other backend for audio. Deprecate (and later remove) 'sdl'
> for audio ?
> 
> IIUC, pipewire is positioned to replace pulseaudio. So if we
> take a pipewire backend, once pipewire is available in enough
> distros we could deprecate the pulseaudio backend and eventually
> remove it. Maybe the same applies for 'jack' ?

AFAIK Pipewire is Linux only, whereas PulseAudio and JACK are available for
Windows and macOS, too. And in it's current version (provided QEMU Pipewire
patch), I don't see it as a full replacement for the JACK driver yet.

> IOW, could we get to
> 
>  - Windows: dsound
>  - MacOS: coreaudio
>  - (Open|Net|Free)BSD: sndio
>  - Linux: alsa/pipewire
> 
> ?
> 
> With regards,
> Daniel
> 




  reply	other threads:[~2023-02-16 11:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15  8:51 [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU Dorinda Bassey
2023-02-15 11:26 ` Daniel P. Berrangé
2023-02-15 13:14   ` Dorinda Bassey
2023-02-16 10:33   ` Michael Tokarev
2023-02-16 10:47     ` Daniel P. Berrangé
2023-02-15 13:18 ` Marc-André Lureau
2023-02-15 14:08   ` Christian Schoenebeck
2023-02-15 14:11     ` Marc-André Lureau
2023-02-15 15:08       ` Daniel P. Berrangé
2023-02-15 15:09       ` Dorinda Bassey
2023-02-16 11:43         ` Gerd Hoffmann
2023-02-15 15:11     ` Gerd Hoffmann
2023-02-15 15:46       ` Dorinda Bassey
2023-02-15 15:59   ` Daniel P. Berrangé
2023-02-16 11:53     ` Christian Schoenebeck [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-02-14  9:23 Dorinda Bassey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3423015.TuE8vhHZVa@silver \
    --to=qemu_oss@crudebyte.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dbassey@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wtaymans@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).